Page MenuHomePhabricator

[regression - wmf.28] The bookmark icon for Saved filters is missing
Closed, ResolvedPublic


On testwiki (and betlabs) Recent Changes page (and other pages with the filters) is missing the bookmark icon - oo-ui-iconElement-icon oo-ui-icon-unClip:

Screen Shot 2018-04-03 at 3.31.52 PM.png (388×1 px, 70 KB)

UBN because filters cannot be saved, although the functionality is in place: the place for the icon can be clicked.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova triaged this task as Unbreak Now! priority.Apr 3 2018, 10:33 PM
Etonkovidova updated the task description. (Show Details)

@Volker_E .... could this have to do with the OOUI icon changes?

@Mooeypoo Yes, it does. We've already got a fix in OOUI dating back a bit.

Change 424021 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@wmf/1.31.0-wmf.28] Revert "RCFilters: Rename deprecated 'unClip' icon to 'bookmark'"

Change 424021 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.28] Revert "RCFilters: Rename deprecated 'unClip' icon to 'bookmark'"

Mentioned in SAL (#wikimedia-operations) [2018-04-04T23:36:45Z] <catrope@tin> Synchronized php-1.31.0-wmf.28/resources/src/mediawiki.rcfilters/: Fix missing bookmark icon (T191366) (duration: 01m 16s)

Etonkovidova claimed this task.

Checked in cawiki/hewiki (wmf.28) - the icon is in place and works as expected.