Page MenuHomePhabricator

TemplateData: Tooltip does not survive scrolling
Closed, ResolvedPublic1 Story Points

Description

When opening a tooltip for a TemplateData parameter the pop-up contains the expected text. When scrolling down however the contents somehow gets squeezed to the left until it disappears completely. See video.

The tooltip pop-up also contains has a horizontal scroll bar which might be the culprit and is anyhow not necessary in the example here.

This occurred to me on Firefox 59.0.2 running on Ubuntu 16.04.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 4 2018, 10:07 AM
Esanders added a subscriber: matmarex.
matmarex claimed this task.Apr 4 2018, 8:02 PM
matmarex edited projects, added VisualEditor (Current work); removed OOUI, VisualEditor.

The clipping bug in OOUI is filed as T180173 and it looked very difficult to fix the last time I looked at it.

However, we can easily avoid it by setting an $overlay, which will allow the popup to expand outside of the dialog, rather than be clipped.

Change 424069 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget

https://gerrit.wikimedia.org/r/424069

For testing, note that you need a template with some TemplateData info for individual parameters. For example:

<templatedata>
{
	"params": {
		"derp": {
			"type": "string",
			"required": true
		}
	},
	"description": "Herp derp?"
}
</templatedata>

Change 424069 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWParameterPage: Pass $overlay to PopupButtonWidget

https://gerrit.wikimedia.org/r/424069

Deskana closed this task as Resolved.Apr 9 2018, 12:20 PM
Deskana set the point value for this task to 1.