Maniphest T191456

[Bug] Not possible to unwatch red links in Watchlist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 4 2018, 7:05 PM

Description

Steps to reproduce

Use testing criteria from https://phabricator.wikimedia.org/T189066
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist

Expected:
Any red links should be accompanied by a green watch star. Clicking the star and refreshing the page should make the article disappear from the watchlist

Actual:

I cannot remove the page from my watchlist

Environments observed

All

Acceptance criteria

Red links loaded via PHP on this page should show as green (see related T191454)
When scrolling newly loaded red links will also be accompanied by a green watchstar
When clicking the green watchstar of a red link the page is removed from the watchstar

Developer notes

A red link has no id. When clicked it triggers an API request using pageid 0 which is incorrect. Clicking it should use the title in the API request rather than the id when id is not available.

Related Objects

Mentioned In: T189066: Watchlist should not show wikidata descriptions, it should show last modified timestamp
Mentioned Here: T191454: Watchlist missing logic is broken and hits the API multiple times unnecessarily on load

Event Timeline

Jdlrobson created this task.Apr 4 2018, 7:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2018, 7:05 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Apr 4 2018, 7:05 PM

Jdlrobson mentioned this in T189066: Watchlist should not show wikidata descriptions, it should show last modified timestamp.

ovasileva triaged this task as Medium priority.Apr 6 2018, 9:20 AM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.Apr 9 2018, 11:47 AM

Should be fixed by T191454, but we'll want to check when that's done.

This should be fixed by T191454. @ABorbaWMF could you please verify? Thank you!

Jdlrobson moved this task from To Do to Needs QA on the Readers-Web-Kanbanana-Board-Old board.May 3 2018, 7:40 PM

Jdlrobson moved this task from Needs Prioritization to 2017-18 Q4 on the Web-Team-Backlog-Archived board.

Yes, tested this yesterday on T191454

all looks good then

	F16679656: Screen Shot 2018-04-04 at 11.58.22 AM.png
	Apr 4 2018, 7:05 PM

	F16679655: Screen Shot 2018-04-04 at 11.58.19 AM.png
	Apr 4 2018, 7:05 PM

[Bug] Not possible to unwatch red links in WatchlistClosed, ResolvedPublicActions