Maniphest T191474

Hard-coded checkmarks need to be replaced by IconWidget
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Apr 4 2018, 9:30 PM

Description

Currently MenuToolGroup gets set a semi hard-coded image in Apex.

.oo-ui-tool-active .oo-ui-tool-link .oo-ui-iconElement-icon {
	.oo-ui-background-image-svg( '@{ooui-default-image-path}/icons/check' );`

We should replace this by an IconWidget instead and show/hide it depending on the theme.

Same applies to MenuOptionWidget (in Apex) and CheckboxInputWidget (in WikimediaUI).

Details

Subject	Repo	Branch	Lines +/-
MenuOptionWidget: Don't specify icon in CSS	oojs/ui	master	+31 -6
CheckboxInputWidget: Don't specify icon in CSS	oojs/ui	master	+39 -27
MenuToolGroup: Don't specify icon in CSS	oojs/ui	master	+29 -16

Customize query in gerrit

Related Objects

Mentioned Here: T191988: [Regression pre-wmf.30] Giant checkmarks appearing in link inspector

Event Timeline

Volker_E created this task.Apr 4 2018, 9:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2018, 9:30 PM

matmarex renamed this task from MenuToolGroup: Hard-coded checkmark needs to be replaced by IconWidget to Hard-coded checkmarks need to be replaced by IconWidget.Apr 5 2018, 1:01 AM

matmarex claimed this task.

matmarex updated the task description. (Show Details)

Also, to document why we need to replace them:

It makes the CSS we deliver smaller
We want to remove the icon set (https://gerrit.wikimedia.org/r/#/c/421781/), so the file this uses would no longer exist

Change 424180 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] MenuOptionWidget: Don't specify icon in CSS

https://gerrit.wikimedia.org/r/424180

Change 424181 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] MenuToolGroup: Don't specify icon in CSS

https://gerrit.wikimedia.org/r/424181

Change 424182 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] CheckboxInputWidget: Don't specify icon in CSS

https://gerrit.wikimedia.org/r/424182

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Apr 5 2018, 7:02 PM

Change 424180 merged by Bartosz Dziewoński:
[oojs/ui@master] MenuOptionWidget: Don't specify icon in CSS

https://gerrit.wikimedia.org/r/424180

Change 424181 merged by Bartosz Dziewoński:
[oojs/ui@master] MenuToolGroup: Don't specify icon in CSS

https://gerrit.wikimedia.org/r/424181

Change 424182 merged by Bartosz Dziewoński:
[oojs/ui@master] CheckboxInputWidget: Don't specify icon in CSS

https://gerrit.wikimedia.org/r/424182

Volker_E moved this task from Reviewing to OOUI-0.26.3 on the OOUI board.Apr 9 2018, 7:08 PM

Volker_E edited projects, added OOUI (OOUI-0.26.3); removed OOUI.

Volker_E closed this task as Resolved.Apr 9 2018, 9:54 PM

Volker_E triaged this task as Medium priority.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

I think patches linked to this ticket are the reason for these checkmarks on CX "New translation" dialog:

new-translation-dialog-checkmarks.PNG (623×795 px, 81 KB)

Another example from VE on enwiki beta.

ve-linktool-checkmark.PNG (484×770 px, 31 KB)

KartikMistry subscribed.Apr 12 2018, 6:34 AM

Ed noticed the same issue, it's filed as T191988: [Regression pre-wmf.30] Giant checkmarks appearing in link inspector and it already has a patch.

	F16913560: new-translation-dialog-checkmarks.PNG
	Apr 11 2018, 10:58 AM

Hard-coded checkmarks need to be replaced by IconWidgetClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Hard-coded checkmarks need to be replaced by IconWidget
Closed, ResolvedPublic
Actions