WikibaseLexeme uses some classes from symfony/validator library for validation of requests to its API modules.
This library is not part of WMF's mediawiki vendor component yet, so it would need to be added there in order to install WikibaseLexeme on WMF's production infrastructure.
Tasks needed in order to achieve this include:
| mediawiki/vendor : master | Added symfony/validator 3.4.9, and symfony/translation 3.4.9 |
| mediawiki/vendor : master | Specify "symfony/translation": "3.4.9" |
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | None | T182986 Selenium framework improvements | ||
| Resolved | • zeljkofilipin | T198389 Q1 Selenium framework improvements | ||
| Open | None | T188742 Run tests daily targeting beta cluster for all repositories with Selenium tests | ||
| Open | WMDE-leszek | T194252 Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata | ||
| Resolved | Addshore | T168260 Deploy WikibaseLexeme extension on Wikimedia cluster | ||
| Resolved | Addshore | T191457 Deploy WikibaseLexeme on www.wikidata.org | ||
| Open | None | T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata | ||
| Resolved | Addshore | T191458 Deploy WikibaseLexeme on test.wikidata.org | ||
| Resolved | Addshore | T191459 Deploy WikibaseLexeme to the Beta Cluster | ||
| Resolved | Addshore | T191463 Add WikibaseLexeme extension to make-wmf-branch script | ||
| Resolved | Addshore | T191507 Add symfony/validator to mediawiki-vendor | ||
| Resolved | None | T191638 Security review of symfony/validator library |
This task will be invalid once https://gerrit.wikimedia.org/r/#/c/427660 is merged per https://gerrit.wikimedia.org/r/#/c/427660/58/composer.json
Let's not jump to conclusions just yet.
@Addshore Aside of the excess work, do you see disadvantages in assuming it will be needed and putting it into the vendor component? We could remove it if it ends up being unused?!
No disadvantages if we are using it.
But right now we are still blocked on T191638 for adding it to mediawiki-vendor.
We could remove it if it ends up being unused?!
Yes.
Change 432098 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/vendor@master] Added symfony/validator 3.4.9, and symfony/translation 4.0.8
Change 432144 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/vendor@master] Specify "symfony/translation": "3.4.9"
Change 432098 merged by jenkins-bot:
[mediawiki/vendor@master] Added symfony/validator 3.4.9, and symfony/translation 3.4.9
Change 432144 merged by jenkins-bot:
[mediawiki/vendor@master] Specify "symfony/translation": "3.4.9"