Page MenuHomePhabricator

PHP fatal error: [] operator not supported for strings @ group0 and group1
Closed, ResolvedPublic

Description

PHP fatal error: [] operator not supported for strings @ https://commons.wikimedia.org/w/index.php?title=Special:AbuseFilter&offset=129

This fatal error has affected group0 and group1.

More details from my local machine:

Error from line 400 of W:\xampp\htdocs\pedia\includes\pager\IndexPager.php: [] operator not supported for strings

Backtrace:

#0 W:\xampp\htdocs\pedia\includes\pager\IndexPager.php(366): IndexPager->buildQueryInfo(string, integer, boolean)
#1 W:\xampp\htdocs\pedia\includes\pager\IndexPager.php(217): IndexPager->reallyDoQuery(string, integer, boolean)
#2 W:\xampp\htdocs\pedia\includes\pager\IndexPager.php(608): IndexPager->doQuery()
#3 W:\xampp\htdocs\pedia\includes\pager\TablePager.php(292): IndexPager->isNavigationBarShown()
#4 W:\xampp\htdocs\pedia\extensions\AbuseFilter\includes\Views\AbuseFilterViewList.php(230): TablePager->getNavigationBar()
#5 W:\xampp\htdocs\pedia\extensions\AbuseFilter\includes\Views\AbuseFilterViewList.php(104): AbuseFilterViewList->showList(string, array)
#6 W:\xampp\htdocs\pedia\extensions\AbuseFilter\includes\special\SpecialAbuseFilter.php(116): AbuseFilterViewList->show()
#7 W:\xampp\htdocs\pedia\includes\specialpage\SpecialPage.php(522): SpecialAbuseFilter->execute(string)
#8 W:\xampp\htdocs\pedia\includes\specialpage\SpecialPageFactory.php(579): SpecialPage->run(string)
#9 W:\xampp\htdocs\pedia\includes\MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#10 W:\xampp\htdocs\pedia\includes\MediaWiki.php(861): MediaWiki->performRequest()
#11 W:\xampp\htdocs\pedia\includes\MediaWiki.php(524): MediaWiki->main()
#12 W:\xampp\htdocs\pedia\index.php(42): MediaWiki->run()
#13 {main}

Event Timeline

Restricted Application added subscribers: Scoopfinder, Aklapper. · View Herald TranscriptApr 5 2018, 9:56 AM
Daimona triaged this task as Unbreak Now! priority.Apr 5 2018, 12:35 PM
Daimona added a subscriber: Daimona.

Due to https://gerrit.wikimedia.org/r/#/c/411593/. Prevents from changing page in Special:AbuseFilter. I'll investigate in a moment.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 5 2018, 12:35 PM
Daimona updated the task description. (Show Details)Apr 5 2018, 12:44 PM

I got the problem, not yet a solution. With getQueryInfo in AbuseFilterPager, we pass as 'conds' a string instead of an array. This is because we need quite a complex query, which we can't achieve with array notation. I'm still looking for a solution.

Change 424305 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Always make $conds an array

https://gerrit.wikimedia.org/r/424305

RazeSoldier renamed this task from PHP fatal error: [] operator not supported for strings @ https://commons.wikimedia.org/w/index.php?title=Special:AbuseFilter&offset=129 to PHP fatal error: [] operator not supported for strings @ group0 and group1.Apr 5 2018, 3:25 PM
RazeSoldier updated the task description. (Show Details)

Change 424345 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.31.0-wmf.28] Remove superfluous line

https://gerrit.wikimedia.org/r/424345

Change 424305 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove superfluous line

https://gerrit.wikimedia.org/r/424305

Change 424345 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@wmf/1.31.0-wmf.28] Remove superfluous line

https://gerrit.wikimedia.org/r/424345

Mentioned in SAL (#wikimedia-operations) [2018-04-05T18:25:35Z] <catrope@tin> Synchronized php-1.31.0-wmf.28/extensions/AbuseFilter/includes/Views/AbuseFilterViewList.php: Unbreak Special:AbuseFilter (T191512) (duration: 01m 17s)

Daimona closed this task as Resolved.Apr 5 2018, 6:28 PM