Page MenuHomePhabricator

Use the trash icon in the saved filters menu
Closed, ResolvedPublic

Description

Currently the saved filters menu uses an "X" for the "remove" action (as shown below), in order to align it with the icon style guide it should use the "trash" icon instead.

CurrentProposed

Event Timeline

Pginer-WMF updated the task description. (Show Details)

Shouldn't it also be “delete“ then?

Catrope added a subscriber: Catrope.Apr 5 2018, 7:01 PM

I think so

Shouldn't it also be “delete“ then?

Makes sense. Let's go with "delete".

Change 439631 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Use the trash icon in the saved filters menu

https://gerrit.wikimedia.org/r/439631

Change 439639 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Add trash icon and add 'delete' to qqq.json

https://gerrit.wikimedia.org/r/439639

Change 439639 merged by jenkins-bot:
[mediawiki/core@master] Use 'trash' icon in the saved filters menu & change 'remove' to 'delete'

https://gerrit.wikimedia.org/r/439639

Change 439631 abandoned by Hagar Shilo:
Use the trash icon in the saved filters menu

Reason:
Resolved in another commit: 21bc31c0c516a7d9840bc42d7c78ec259065e9ad

https://gerrit.wikimedia.org/r/439631

Etonkovidova closed this task as Resolved.Jun 13 2018, 9:58 PM
Etonkovidova added a subscriber: Etonkovidova.

Checked in supported browsers and skins - looks according to the specs: