Page MenuHomePhabricator
Create Task
Maniphest T191530

Use the trash icon in the saved filters menu
Closed, ResolvedPublic
Actions

Assigned To
Hagarshilo
Authored By
Pginer-WMF
Apr 5 2018, 2:23 PM
Tags
Referenced Files
F22198030: Screen Shot 2018-06-13 at 2.56.20 PM.png
Jun 13 2018, 9:58 PM
F16709524: Screen Shot 2018-04-05 at 16.23.48.png
Apr 5 2018, 2:24 PM
F16709302: Screen Shot 2018-04-05 at 16.20.18.png
Apr 5 2018, 2:23 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
• jmatazzoni
Mooeypoo
Pginer-WMF
View All 9 Subscribers

Description

Currently the saved filters menu uses an "X" for the "remove" action (as shown below), in order to align it with the icon style guide it should use the "trash" icon instead.

CurrentProposed
Screen Shot 2018-04-05 at 16.20.18.png (232×360 px, 20 KB)
Screen Shot 2018-04-05 at 16.23.48.png (233×352 px, 19 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use the trash icon in the saved filters menumediawiki/coremaster+2 -2
Use 'trash' icon in the saved filters menu & change 'remove' to 'delete'mediawiki/coremaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Apr 5 2018, 2:23 PM
Pginer-WMF updated the task description. (Show Details)
Volker_E subscribed.Apr 5 2018, 6:58 PM

Shouldn't it also be “delete“ then?

Catrope subscribed.Apr 5 2018, 7:01 PM

I think so

Pginer-WMF added a comment.Apr 6 2018, 9:14 AM
In T191530#4110014, @Volker_E wrote:

Shouldn't it also be “delete“ then?

Makes sense. Let's go with "delete".

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Apr 10 2018, 7:00 PM
• jmatazzoni moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Mooeypoo assigned this task to Hagarshilo.Jun 11 2018, 4:27 PM
Mooeypoo moved this task from Snack Box to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot subscribed.Jun 11 2018, 5:13 PM

Change 439631 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Use the trash icon in the saved filters menu

https://gerrit.wikimedia.org/r/439631

gerritbot added a project: Patch-For-Review.Jun 11 2018, 5:13 PM
Hagarshilo moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 11 2018, 5:18 PM
gerritbot added a comment.Jun 11 2018, 5:58 PM

Change 439639 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Add trash icon and add 'delete' to qqq.json

https://gerrit.wikimedia.org/r/439639

gerritbot added a comment.Jun 13 2018, 2:37 PM

Change 439639 merged by jenkins-bot:
[mediawiki/core@master] Use 'trash' icon in the saved filters menu & change 'remove' to 'delete'

https://gerrit.wikimedia.org/r/439639

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 13 2018, 3:00 PM
gerritbot added a comment.Jun 13 2018, 3:26 PM

Change 439631 abandoned by Hagar Shilo:
Use the trash icon in the saved filters menu

Reason:
Resolved in another commit: rMW21bc31c0c516

https://gerrit.wikimedia.org/r/439631

Hagarshilo moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 13 2018, 3:40 PM
Etonkovidova closed this task as Resolved.Jun 13 2018, 9:58 PM
Etonkovidova subscribed.

Checked in supported browsers and skins - looks according to the specs:

Screen Shot 2018-06-13 at 2.56.20 PM.png (324×448 px, 24 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits