Page MenuHomePhabricator

Use the trash icon in the saved filters menu
Closed, ResolvedPublic

Description

Currently the saved filters menu uses an "X" for the "remove" action (as shown below), in order to align it with the icon style guide it should use the "trash" icon instead.

CurrentProposed
Screen Shot 2018-04-05 at 16.20.18.png (232×360 px, 20 KB)
Screen Shot 2018-04-05 at 16.23.48.png (233×352 px, 19 KB)

Event Timeline

Shouldn't it also be “delete“ then?

Shouldn't it also be “delete“ then?

Makes sense. Let's go with "delete".

Change 439631 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Use the trash icon in the saved filters menu

https://gerrit.wikimedia.org/r/439631

Change 439639 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Add trash icon and add 'delete' to qqq.json

https://gerrit.wikimedia.org/r/439639

Change 439639 merged by jenkins-bot:
[mediawiki/core@master] Use 'trash' icon in the saved filters menu & change 'remove' to 'delete'

https://gerrit.wikimedia.org/r/439639

Change 439631 abandoned by Hagar Shilo:
Use the trash icon in the saved filters menu

Reason:
Resolved in another commit: rMW21bc31c0c516

https://gerrit.wikimedia.org/r/439631

Etonkovidova added a subscriber: Etonkovidova.

Checked in supported browsers and skins - looks according to the specs:

Screen Shot 2018-06-13 at 2.56.20 PM.png (324×448 px, 24 KB)