Or maybe this is a filter for Sp:BlockList.

Yes. I don't think this should be a whole new page.

Making the Items per page dropdown narrower and adding a new Type dropdown there makes sense. It's good that it doesn't increase the size of the filter section either.

Make the 'Items' dropdown 50% width and add a dropdown to its right (on LTR lang wikis)

Lets add the Type dropdown to its left though, its a more important filter and should surface earlier.

In T191549#4983573, @Prtksxna wrote:

Make the 'Items' dropdown 50% width and add a dropdown to its right (on LTR lang wikis)

Lets add the Type dropdown to its left though, its a more important filter and should surface earlier.

Can do. I'll update the task. Thank you!

Change 502543 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Add block type filter to Special:BlockList

https://gerrit.wikimedia.org/r/502543

Copying from gerrit, a question about the acceptance criterion:

• If a user configures a search that results in no results, the existing 'no results' message should be displayed (The requested IP address or username is not blocked.)

If someone is sitewide blocked, and the list is filtered to their username with block type Partial, the message says "The requested IP address or username is not blocked." This is not true any more. Should we change that message (ipblocklist-no-results) to something like: "No blocks found for the requested IP address or username."?

In T191549#5112283, @Tchanders wrote:

If someone is sitewide blocked, and the list is filtered to their username with block type Partial, the message says "The requested IP address or username is not blocked." This is not true any more. Should we change that message (ipblocklist-no-results) to something like: "No blocks found for the requested IP address or username."?

Good catch, I would say so. @aezell, @Niharika what do you think?

It could definitely be misleading. Maybe something like "No matching blocks found..." is even more exact?

I like Alex's idea! Something like:

• No matching blocks found for the requested IP address or username OR
• No blocks found for the requested IP address or username matching the search criteria

should be fine.

I'm going with No matching blocks found for the requested IP address or username

Change 502543 merged by jenkins-bot:
[mediawiki/core@master] Add block type filter to Special:BlockList

https://gerrit.wikimedia.org/r/502543

I checked that filters were applied correctly for a combination of conditions (sitewide/partial, temporary, IP/Range/User).

I also checked that these were preserved across pagination.

For b/w compatibility, I checked the filter works when $wgEnablePartialBlocks is not set.

I did notice that blocks which don't block editing (i.e. only block account creation or emailing) are counted as partial. I have never thought of this before, but it makes sense. @Niharika ?

I did notice that blocks which don't block editing (i.e. only block account creation or emailing) are counted as partial.

Making this type of block became possible due to the way partial blocks was implemented (i.e. not requiring any restrictions when the flag is set to partial), but I'm not sure where that decision came from or whether it was part of the original brief for partial blocks.

Change 512370 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] SpecialBlockList: Merge stylesheet in into 'mediawiki.special' bundle

https://gerrit.wikimedia.org/r/512370

Change 512370 merged by jenkins-bot:
[mediawiki/core@master] SpecialBlockList: Merge stylesheet in into 'mediawiki.special' bundle

https://gerrit.wikimedia.org/r/512370