Page MenuHomePhabricator
Create Task
Maniphest T191557

FilterMenuHeaderWidget: Back button `padding` wrongly applied to parent element
Open, Needs TriagePublic
Actions

Description

Back button on Namespaces and Tags currently features padding on parent element.

Expected result:

  • padding when button is invisible shouldn't be there

Details

Related Gerrit Patches:
mediawiki/core : masterRCFilters: Adjust unbalanced scan line in filter menu

Related Objects
Search...

Event Timeline

Volker_E created this task.Apr 5 2018, 6:50 PM
Volker_E added a subscriber: Catrope.Apr 9 2018, 10:35 PM

From a conversation with @Catrope, it's visible as soon as for example Namespaces are selected to be filtered. The padding though shouldn't be visible by default.

Volker_E renamed this task from FilterMenuHeaderWidget: Back button to FilterMenuHeaderWidget: Back button `padding`.Apr 9 2018, 10:37 PM
Volker_E updated the task description. (Show Details)
gerritbot added a subscriber: gerritbot.Apr 9 2018, 11:10 PM

Change 424374 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Adjust unbalanced scan line in filter menu

https://gerrit.wikimedia.org/r/424374

Volker_E renamed this task from FilterMenuHeaderWidget: Back button `padding` to FilterMenuHeaderWidget: Back button `padding` wrongly applied to parent element.Apr 9 2018, 11:36 PM
Volker_E updated the task description. (Show Details)
Volker_E claimed this task.Apr 12 2018, 1:17 AM
Volker_E removed a project: Patch-For-Review.
gerritbot added a comment.Apr 12 2018, 1:17 AM

Change 424374 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Adjust unbalanced scan line in filter menu

https://gerrit.wikimedia.org/r/424374

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 10:09 AM
Trizek-WMF moved this task from Inbox to External on the Growth-Team board.Sep 4 2018, 5:34 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL