Page MenuHomePhabricator

InteractionTimeline fails with error 400 when selecting an IP user
Closed, ResolvedPublic3 Estimated Story Points

Description

InteractionTimeline fails with error 400 when selecting an IP user

Just what it says on the tin:

Error example:

Error 400
username x.x.x.x could not be found

https://tools.wmflabs.org/interaction-timeline/?wiki=testwiki&user=198.73.209.241&user=TBolliger%20(WMF)&startDate=1520640000

Screen Shot 2018-04-09 at 9.41.13 AM.png (943×1 px, 172 KB)

Event Timeline

dmaza triaged this task as High priority.Apr 6 2018, 3:15 PM

Yeah, the issue here is that we try to load the user id from the user name in the request. It obviously doesn't work for IP(s)

It should either be fixed to work with IP's, or fix the workflow to result in a graceful denial instead of a protocol error. I'd much prefer the former.

We want to support querying for IP address users. This is a regression from our work in T180653: Interaction Timeline V1: Support IP users

It should either be fixed to work with IP's, or fix the workflow to result in a graceful denial instead of a protocol error. I'd much prefer the former.

The bug is valid. This was an oversight on my end when working on performance improvements. It will work for IP(s).

TBolliger set the point value for this task to 3.Apr 11 2018, 6:56 PM
dmaza moved this task from Review to Done on the Anti-Harassment (AHT Sprint 21/22) board.