Page MenuHomePhabricator

Remove Thanks for autopromote log
Open, LowPublic3 Story Points


Since yesterday thanking for log entries is possible. Great. Thanks a lot :-)

But the thank function for autopromote log actions is IMHO useless:

Event Timeline

Raymond created this task.Apr 6 2018, 8:11 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 6 2018, 8:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TBolliger set the point value for this task to 3.
TBolliger triaged this task as Low priority.Apr 11 2018, 11:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 5 2018, 1:45 PM
Catrope added a subscriber: Catrope.Jan 8 2019, 5:54 AM

This happens because the ThanksLogTypeWhitelist config only lists top-level log types, not type+action combinations (subtypes, basically). In this case, it lists the type rights, but we really only want to allow thanks for rights/rights, not for rights/autopromote. A code change would be needed to accept subtypes in this list.

Setian added a subscriber: Setian.EditedFeb 25 2019, 1:38 AM

So how do you want to do this; should it be set up like:

$wgThanksLogTypeWhitelist = [

Or like:

$wgThanksLogTypeWhitelist = [
	["rights" => "rights"]

Change 492595 had a related patch set uploaded (by Setian; owner: Setian):
[mediawiki/extensions/Thanks@master] Allow the log type whitelist to have entries like "rights/rights"

Change 492595 abandoned by MaxSem:
Allow the log type whitelist to have entries like "rights/rights"

Banned user.

@MaxSem This shouldn't matter, as the code is fine. I would be willing to adopt this change.

I'm not really able to find a reason why this user has been banned anyway. He's made some quite controversal suggestions, but from what I've seen he hasn't behaved that badly.