Remove Thanks for autopromote log
Open, LowPublic3 Story Points


Since yesterday thanking for log entries is possible. Great. Thanks a lot :-)

But the thank function for autopromote log actions is IMHO useless:

Raymond created this task.Apr 6 2018, 8:11 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 6 2018, 8:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TBolliger set the point value for this task to 3.
TBolliger triaged this task as Low priority.Apr 11 2018, 11:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 5 2018, 1:45 PM
Trizek-WMF moved this task from Inbox to To Triage on the Growth-Team board.Dec 13 2018, 9:49 AM
Catrope added a subscriber: Catrope.Tue, Jan 8, 5:54 AM

This happens because the ThanksLogTypeWhitelist config only lists top-level log types, not type+action combinations (subtypes, basically). In this case, it lists the type rights, but we really only want to allow thanks for rights/rights, not for rights/autopromote. A code change would be needed to accept subtypes in this list.

Catrope added a project: good first bug.