Page MenuHomePhabricator
Create Task
Maniphest T191600

Showing the lemma in recent changes
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
• Pablo-WMDE
Authored By
Lydia_Pintscher
Apr 6 2018, 8:27 AM
Tags
Referenced Files
F19005863: Bildschirmfoto vom 2018-06-08 16-15-33.png
Jun 8 2018, 2:20 PM
F16745179: Screenshot_20180406_102138.png
Apr 6 2018, 8:27 AM
Subscribers
Aklapper
gerritbot
Lydia_Pintscher
WMDE-leszek

Description

As a user I want to be able to quickly see what is behind a Lexeme ID I see in recent changes in order to know if the edit summary associated with it represents a good or bad edit.

Screenshot_20180406_102138.png (232×1 px, 77 KB)

The recent changes line should start with for example "Lehrerin (L123)" instead of "L123" if Lehrerin is the lemma.

GIVEN There has been an edit made to the Lexeme
WHEN I am on Special:RecentChanges
THEN I see the lemma of the lexeme and the ID
AND they link to the lexeme page

Details:

  • If there are multiple then show them separated by translatable separator (in English forward slash) in the order in which they are in the Lexeme.

Todo:

  • Consider adding a browser test or another high level test

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexememaster+1 -1selenium: Changed RecentChanges page object
mediawiki/coremaster+2 -7selenium: RecentChanges page object
mediawiki/extensions/WikibaseLexememaster+44 -0LexemeLinkFormatter: test it is used
mediawiki/coremaster+47 -0selenium: add RecentChanges test to page spec
Customize query in gerrit

Related Objects

Event Timeline

Lydia_Pintscher created this task.Apr 6 2018, 8:27 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptApr 6 2018, 8:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher updated the task description. (Show Details)Apr 6 2018, 8:32 AM
WMDE-leszek updated the task description. (Show Details)Apr 24 2018, 3:19 PM
WMDE-leszek set the point value for this task to 5.
Lydia_Pintscher triaged this task as High priority.May 8 2018, 12:48 PM
• Pablo-WMDE mentioned this in T195315: Showing the Lemma(s) or Representation(s) when Lexemes or Forms are mentioned in constraint reports.May 23 2018, 10:47 AM
Lydia_Pintscher added a comment.May 30 2018, 9:42 AM

Potentially going to be fixed with T195382.

• Pablo-WMDE updated the task description. (Show Details)Jun 6 2018, 1:41 PM
• Pablo-WMDE changed the point value for this task from 5 to 3.
• Pablo-WMDE claimed this task.Jun 8 2018, 2:04 PM
• Pablo-WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration0.
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration0 board.
• Pablo-WMDE added a subscriber: WMDE-leszek.Jun 8 2018, 2:20 PM

@Lydia_Pintscher Observation that could irritate users. We are using the lemmas of a lexeme to build its anchor text. Special:RecentChanges shows the development of entities over time, i.e. multiple revisions of the same entity. However all anchor texts are built using the latest revision of the entity and as such may contain lemma that were not part of the lexeme at the time the change refers to. This could go counter to the stated intention of this ticket, to "know if the edit summary associated with it represents a good or bad edit".

Bildschirmfoto vom 2018-06-08 16-15-33.png (439×1 px, 103 KB)

/cc @WMDE-leszek

Lydia_Pintscher added a comment.Jun 9 2018, 1:46 PM

Thanks for paying attention, Pablo! We're doing the same for items. No-one asked for a change to that afaik. And it could be argued that the most recent label/lemma is what identifies the item no matter what it's been in the past.

gerritbot added a subscriber: gerritbot.Jun 12 2018, 11:21 AM

Change 439878 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/core@master] selenium: add RecentChanges test to page spec

https://gerrit.wikimedia.org/r/439878

gerritbot added a project: Patch-For-Review.Jun 12 2018, 11:21 AM
gerritbot added a comment.Jun 12 2018, 3:43 PM

Change 439951 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] LexemeLinkFormatter: test it is used

https://gerrit.wikimedia.org/r/439951

• Pablo-WMDE mentioned this in rEWLE2ff9dc3454e6: LexemeLinkFormatter: test it is used.Jun 12 2018, 3:46 PM
Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration1.Jun 13 2018, 9:20 AM
• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 9:25 AM
• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 9:57 AM
• Pablo-WMDE moved this task from Peer Review to Doing on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 13 2018, 1:37 PM
gerritbot added a comment.Jun 14 2018, 7:44 AM

Change 439878 merged by jenkins-bot:
[mediawiki/core@master] selenium: add RecentChanges test to page spec

https://gerrit.wikimedia.org/r/439878

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 14 2018, 8:00 AM
• Pablo-WMDE mentioned this in rEWLEe0889b26029d: LexemeLinkFormatter: test it is used.Jun 14 2018, 8:37 AM
• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 14 2018, 8:53 AM
• Pablo-WMDE mentioned this in rEWLE615ab3d27923: LexemeLinkFormatter: test it is used.Jun 14 2018, 1:35 PM
• Pablo-WMDE mentioned this in rEWLE73f935faaa03: LexemeLinkFormatter: test it is used.
Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration1 board.Jun 15 2018, 8:56 AM
gerritbot added a comment.Jun 15 2018, 9:09 AM

Change 439951 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] LexemeLinkFormatter: test it is used

https://gerrit.wikimedia.org/r/439951

Lydia_Pintscher closed this task as Resolved.Jun 15 2018, 4:57 PM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration1 board.
gerritbot added a comment.Jun 19 2018, 1:34 PM

Change 441039 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/core@master] selenium: RecentChanges page object

https://gerrit.wikimedia.org/r/441039

gerritbot added a comment.Jun 19 2018, 1:40 PM

Change 441041 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] selenium: Changed RecentChanges page object

https://gerrit.wikimedia.org/r/441041

• Pablo-WMDE mentioned this in rEWLE378559475c1b: selenium: Changed RecentChanges page object.Jun 19 2018, 1:42 PM
gerritbot added a comment.Jun 19 2018, 2:44 PM

Change 441039 merged by jenkins-bot:
[mediawiki/core@master] selenium: RecentChanges page object

https://gerrit.wikimedia.org/r/441039

gerritbot added a comment.Jun 19 2018, 2:51 PM

Change 441041 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] selenium: Changed RecentChanges page object

https://gerrit.wikimedia.org/r/441041

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 26 2018, 6:01 PM
• Pablo-WMDE added a comment.Jul 12 2018, 1:10 PM

This introduced browser tests for core which are flaky T198137 (see #3)

Krinkle mentioned this in T219584: Flaky wdio test "RecentChanges shows lemmas in title links".Apr 8 2019, 1:02 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL