l10n_test check the validity of templates on reals wiki and verifys wether the template really exists. It is not necessary to run these test for every instance of the test matrix. Running it once for each commited patch would be enough. Or to reduce the test time further it would be sufficient to run one test when i18n submodule is updated.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [bugfix] Re-enable l10n_tests | pywikibot/core | master | +4 -7 | |
| [tests] Run L10N tests on Travis only once for each patch | pywikibot/core | master | +10 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T152961 Improve tests suite | |||
| Resolved | Xqt | T186323 Travis and Appveyor: Major improvement to test time | |||
| Declined | Xqt | T191632 l10n_tests should run only once for every committed patch |
Event Timeline
Comment Actions
Change 462912 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Run L10N tests only once for each patch
Comment Actions
I've no glue whether that configuration matrix in .travis.yml inside i18n repository ever runs.
Comment Actions
I just found b9670d9afd006969322481bf321d27e4a815d362 and I'm wondering why it's not working.
Comment Actions
The whole handling with disabled_test_modules is a bit weird:
Line 151
disabled_test_modules = [
'tests', # tests of the tests package
'l10n',
]OK, these will be disabled
Line 155
if not i18n.messages_available():
disabled_test_modules.append('l10n')Isn't it already in the list?
Line 187
if 'PYWIKIBOT_TEST_MODULES' in os.environ:
disabled_test_modules = set(test_modules) - set(_enabled_test_modules)Now we overwrite it even before we use it?
Comment Actions
The test could be done in i18n repository but it seems no tests are done there but the bot verify with +2 together with CR+2
Comment Actions
Change 462912 merged by jenkins-bot:
[pywikibot/core@master] [tests] Run L10N tests on Travis only once for each patch
Comment Actions
Change 474543 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Re-enable l10n_tests
Comment Actions
Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)
Comment Actions
l10n tests are disabled for pywikibot-core but Jenkins runs it for every patch submitted to pywikibot-i18n