Page MenuHomePhabricator

l10n_tests should run only once for every committed patch
Closed, DeclinedPublic

Description

l10n_test check the validity of templates on reals wiki and verifys wether the template really exists. It is not necessary to run these test for every instance of the test matrix. Running it once for each commited patch would be enough. Or to reduce the test time further it would be sufficient to run one test when i18n submodule is updated.

Event Timeline

This comment has been deleted.

Change 462912 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Run L10N tests only once for each patch

https://gerrit.wikimedia.org/r/462912

Xqt raised the priority of this task from Low to Medium.Sep 26 2018, 12:35 PM

I've no glue whether that configuration matrix in .travis.yml inside i18n repository ever runs.

The whole handling with disabled_test_modules is a bit weird:

Line 151
disabled_test_modules = [
    'tests',  # tests of the tests package
    'l10n',
]

OK, these will be disabled

Line 155
if not i18n.messages_available():
    disabled_test_modules.append('l10n')

Isn't it already in the list?

Line 187
if 'PYWIKIBOT_TEST_MODULES' in os.environ:
    disabled_test_modules = set(test_modules) - set(_enabled_test_modules)

Now we overwrite it even before we use it?

The test could be done in i18n repository but it seems no tests are done there but the bot verify with +2 together with CR+2

Framawiki assigned this task to Xqt.

Change 462912 merged by jenkins-bot:
[pywikibot/core@master] [tests] Run L10N tests on Travis only once for each patch

https://gerrit.wikimedia.org/r/462912

As I can see no tests where made

Change 474543 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Re-enable l10n_tests

https://gerrit.wikimedia.org/r/474543

Aklapper removed Xqt as the assignee of this task.Jul 2 2021, 5:21 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

l10n tests are disabled for pywikibot-core but Jenkins runs it for every patch submitted to pywikibot-i18n