Maniphest T191658

hide-if and flatlist do not cooperate well
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matej_suchanek
	Apr 6 2018, 7:15 PM

Description

In https://gerrit.wikimedia.org/r/#/c/424245/ and https://gerrit.wikimedia.org/r/#/c/424652/ I want to make use of [[ https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/htmlform/HTMLForm.php;48a6894abbb26e5e93437bf30cf0fee54db052a4$94 | hide-if ]] setting to conditional show/hide some form elements.

The element to be hidden (highlighted in the screenshots) is 'type' => 'radio' with 'flatlist' => true. The screenshots show that the look is different with and without hide-if (if it's used, flatlist is ignored).

without hide-if	with hide-if

Related Objects

Mentioned In: T217227: Extend abuse filter search to include warning and disallow message names

Event Timeline

matej_suchanek created this task.Apr 6 2018, 7:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2018, 7:15 PM

Daimona awarded a token.Apr 6 2018, 7:36 PM

I investigated a bit. The problem comes from the infusion performed here. In fact, as the element is infused it loses the flatlist property. I still have to determine the specific reason, though.

Daimona mentioned this in T217227: Extend abuse filter search to include warning and disallow message names.Feb 27 2019, 8:00 AM

This is now working as expected, likely fixed independently by someone.

hide-if and flatlist do not cooperate wellClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

hide-if and flatlist do not cooperate well
Closed, ResolvedPublic
Actions