Maniphest T191683

missing html links for Phabricator Blog feeds
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Dzahn
	Apr 7 2018, 1:11 AM

Description

In https://planet.wikimedia.org we also include several RSS/Atom feeds from Phabricator.

Today i noticed this in logs:

DEBUG:planet.runner:missing html link for https://phabricator.wikimedia.org/phame/blog/feed/1/
DEBUG:planet.runner:missing html link for https://phabricator.wikimedia.org/phame/blog/feed/5/
DEBUG:planet.runner:missing html link for https://phabricator.wikimedia.org/phame/blog/feed/7/
DEBUG:planet.runner:missing html link for https://phabricator.wikimedia.org/phame/blog/feed/8/
DEBUG:planet.runner:missing html link for https://phabricator.wikimedia.org/phame/blog/feed/9/

Event Timeline

Dzahn created this task.Apr 7 2018, 1:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2018, 1:11 AM

Peachey88 edited projects, added Phabricator (Upstream); removed Phabricator.Apr 7 2018, 5:55 AM

Peachey88 updated the task description. (Show Details)

Restricted Application added a project: Upstream. · View Herald TranscriptApr 7 2018, 5:55 AM

Aklapper triaged this task as Lowest priority.May 30 2021, 9:36 AM

How would an expected non-missing html link look like and where? Is this some header? What is Planet expecting exactly?

# warn on missing links
if not data.feed.has_key('planet_message'):
    if not data.feed.has_key('links'): data.feed['links'] = []

    for link in data.feed.links:
      if link.rel == 'self': break
    else:
      log.debug('missing self link for ' + sub)

    for link in data.feed.links:
      if link.rel == 'alternate' and 'html' in link.type: break
    else:
      log.debug('missing html link for ' + sub)

it's expecting a "links" item in the actual feed, returned by feedparser

This is code from the old "planet-venus" code base (https://www.intertwingly.net/code/venus/) that we do not use anymore.

Also this does not appear in current logs, i checked.

We can safely close this as irrelevant now.

Dzahn closed this task as Declined.Nov 6 2023, 7:23 PM

missing html links for Phabricator Blog feedsClosed, DeclinedPublicActions

Description

Event Timeline

missing html links for Phabricator Blog feeds
Closed, DeclinedPublic
Actions