Maniphest T191693

Restore toolbar border in SD+WMUI/Vector
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Apr 7 2018, 12:38 PM

Tags

Referenced Files

	F16964727: Screen Shot 2018-04-13 at 5.59.59 PM.png
	Apr 14 2018, 1:05 AM

	F16789226: image.png
	Apr 7 2018, 12:40 PM

	F16789220: image.png
	Apr 7 2018, 12:38 PM

	F16789217: image.png
	Apr 7 2018, 12:38 PM

Subscribers

Description

When the border was removed for Apex this made more sense as each tool has its own border:

image.png (260×225 px, 5 KB)

However in the latest WMUI we end up border-less fill areas:

image.png (261×236 px, 6 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use toolbar border in WMUI	mediawiki/extensions/Flow	master	+11 -4

Customize query in gerrit

Event Timeline

Esanders created this task.Apr 7 2018, 12:38 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 7 2018, 12:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

After:

image.png (318×265 px, 6 KB)

Change 424759 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Restore toolbar border in WMUI

https://gerrit.wikimedia.org/r/424759

gerritbot added a project: Patch-For-Review.Apr 7 2018, 12:42 PM

Change 424759 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use toolbar border in WMUI

https://gerrit.wikimedia.org/r/424759

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 10 2018, 6:00 PM

List Item

• jmatazzoni moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 10 2018, 6:46 PM

Verified in betalabs:

Screen Shot 2018-04-13 at 5.59.59 PM.png (349×323 px, 17 KB)