Page MenuHomePhabricator

Checkuser logs SUL attachings caused by page imports under importer's IP/UA
Open, MediumPublic

Description

While importing a page on a wiki where an account doesn't exist a SUL autocreation is triggered. Such these autocreations are logged by checkuser extension under importer's IP/UA. This kind of behavior produces pure noise which should, IMHO be avoided.

Event Timeline

This is related to T44345 in that in both cases, the IP that should be used should be an invalid IP (such as 127.0.0.1) indicating that this is something the server is doing, not something a user is doing.

We have a patch for that (https://gerrit.wikimedia.org/r/#/c/92050/) which would allow overriding the IP address of an RC event, but it is still stuck in code reviewer. @Legoktm created that patch, and I encourage him to revisit the patch and respond to the review comments (by me). Once that is in place, we can hopefully use the same strategy in Special:Import and/or SUL code to override the IP there as well.

Huji triaged this task as Medium priority.Apr 7 2018, 11:33 PM

The IP stored could be a internal or invalid IP. It is at the moment possible to check 127.0.0.1 and as such sending software defined actions there may not be desirable. Instead storing an empty string as the IP could be a way to deal with this. The lack of content in cuc_ip could then be used to indicate to the software to show instead the IP is 'internal' or 'the software'.

I don't see any reason why someone would need to run a check on actions performed by the software as there wouldn't be CU specific information that would be not representing that the software did this action. The IP would indicate that the software did this, and the user agent and XFF would both be blank or indicate that it was a software performed action. Apart from that there isn't anything that Special:Log wouldn't already tell you as this is not a restricted log (so all CUs could see this anyway).

Dreamy_Jazz changed the task status from Open to Stalled.Sep 29 2022, 8:24 PM

Waiting on subtask to have it's patch merged.

Dreamy_Jazz changed the task status from Stalled to Open.Oct 11 2022, 7:54 PM

Subtask resolved and progress can now be made.

Adding MediaWiki-General as the code fix needs to be in core where the code that performs the import.