Maniphest T191738

Bundle Echo extension with MediaWiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	CCicalese_WMF
	Apr 8 2018, 6:25 PM

Description

Passed security review or already Wikimedia deployed
Voting CI structure tests
Runs MediaWiki-CodeSniffer
Runs phan
Supports MySQL, SQLite, and Postgres (if there are schema changes)
GPL v2 or later compatible license
Extension's default configuration provides optimal experience
Tested with web installer

Details

	Reference	Source Branch	Dest Branch	Author	Title
	repos/releng/release!10	tarball-echo-plus	master	jforrester	Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle

Customize query in GitLab

Related Objects
Search...

Status	Assigned	Task
Open	None	T317146 Expand the set of bundled extensions and skins in MediaWiki 1.40
Resolved	Jdforrester-WMF	T191746 Bundle LoginNotify extension with MediaWiki
Resolved	Jdforrester-WMF	T191739 Bundle Thanks extension with MediaWiki
Resolved	Jdforrester-WMF	T191738 Bundle Echo extension with MediaWiki
Resolved	demon	T186456 PHP Fatal error: Call to undefined method PEAR::encodeHeader() when Echo is enabled
Resolved	Umherirrender	T244898 Notifications ('Echo') should work with postgres
Resolved	None	T244899 CentralAuth should work with postgres
Resolved	Umherirrender	T259376 Migrate CentralAuth to Abstract Schema
Resolved	Umherirrender	T300576 Standardise type for timestamp columns in CentralAuth extension
Resolved	Jdforrester-WMF	T259375 Migrate Echo to Abstract Schema
Resolved	Umherirrender	T306473 Drop foreign keys from echo table echo_push_subscription
Resolved	Legoktm	T31134 installer breaks when extensions depend on each other

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

CCicalese_WMF added a parent task: T178349: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites.Apr 8 2018, 6:28 PM

Tgr added a subscriber: Tgr.Apr 8 2018, 8:56 PM

Legoktm removed a project: MediaWiki-Installer.Apr 9 2018, 1:38 AM

Legoktm added a subtask: T191746: Bundle LoginNotify extension with MediaWiki.Apr 9 2018, 2:18 AM

Legoktm updated the task description. (Show Details)Apr 9 2018, 2:21 AM

Legoktm added a subtask: T191739: Bundle Thanks extension with MediaWiki.Apr 9 2018, 2:23 AM

Legoktm removed a subtask: T191746: Bundle LoginNotify extension with MediaWiki.Apr 9 2018, 2:31 AM

Legoktm added a parent task: T191746: Bundle LoginNotify extension with MediaWiki.

Legoktm removed a subtask: T191739: Bundle Thanks extension with MediaWiki.

Legoktm added a parent task: T191739: Bundle Thanks extension with MediaWiki.

cicalese added a project: Notifications.Apr 17 2018, 12:26 AM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 17 2018, 12:26 AM

CCicalese_WMF updated the task description. (Show Details)Apr 17 2018, 8:25 PM

Legoktm added a subtask: T186456: PHP Fatal error: Call to undefined method PEAR::encodeHeader() when Echo is enabled.Apr 26 2018, 5:32 AM

demon moved this task from Backlog to Extension bundling on the MW-1.31-release board.Apr 26 2018, 7:32 PM

demon closed subtask T186456: PHP Fatal error: Call to undefined method PEAR::encodeHeader() when Echo is enabled as Resolved.May 24 2018, 10:26 PM

CCicalese_WMF renamed this task from Bundle Echo extension with MW 1.31 to Bundle Echo extension with MW 1.32.Jun 7 2018, 3:56 PM

CCicalese_WMF edited parent tasks, added: T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32; removed: T178349: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites.

CCicalese_WMF edited projects, added MW-1.32-release; removed MW-1.31-release.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 10:33 AM

MGChecker added a subscriber: MGChecker.Sep 2 2018, 7:51 PM

SBisson moved this task from Inbox to External on the Growth-Team board.Sep 7 2018, 12:19 PM

MGChecker mentioned this in T191739: Bundle Thanks extension with MediaWiki.Sep 8 2018, 11:24 PM

Legoktm moved this task from Backlog to Bundling additions on the MW-1.32-release board.Oct 9 2018, 12:40 AM

License is MIT which is compatible with GPL 2+.

MGChecker updated the task description. (Show Details)Oct 12 2018, 9:10 AM

CCicalese_WMF renamed this task from Bundle Echo extension with MW 1.32 to Bundle Echo extension with MediaWiki.Nov 10 2018, 6:49 PM

CCicalese_WMF mentioned this in T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34.Nov 10 2018, 6:58 PM

CCicalese_WMF edited parent tasks, added: T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34; removed: T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32.Nov 10 2018, 7:04 PM

CCicalese_WMF edited projects, added MW-1.33-release; removed MW-1.32-release.Nov 21 2018, 3:06 PM

MGChecker moved this task from Backlog to Bundling additions on the MW-1.33-release board.Dec 21 2018, 9:26 AM

Jdforrester-WMF edited projects, added MW-1.34-release; removed MW-1.33-release.Jun 7 2019, 9:00 PM

Krinkle moved this task from Blocker to Bundling additions on the MW-1.34-release board.Jun 15 2019, 12:28 AM

What is the situation with respect to database support?

CCicalese_WMF mentioned this in T191746: Bundle LoginNotify extension with MediaWiki.Sep 13 2019, 4:35 PM

CCicalese_WMF triaged this task as Medium priority.Sep 13 2019, 4:48 PM

@Anomie, do you have any insight into the database support in Echo?

In T191738#5491381, @CCicalese_WMF wrote:

@Anomie, do you have any insight into the database support in Echo?

I think sqlite and mysql are good. Postgres if it works, is more by accident (ie the sql works there too) than any sort of planning

In T191738#5491386, @Reedy wrote:

Postgres if it works, is more by accident (ie the sql works there too) than any sort of planning

It almost certainly doesn't work then, since for example the syntax for defining auto-incrementing ID fields is different, PG doesn't have "unsigned", and other incompatibilities.

It might work if someone were to write the schema for it and wire it into EchoHooks::onLoadExtensionSchemaUpdates(). MediaWiki's DQL and DML abstractions are pretty good if used right, it's just the DDL that's almost completely not abstracted.

Based on the determination above, and that clearly we are not going to get DB schemata written, tested, and merged in the next 11 days when there are no volunteers who care about PG support around, I'm moving this and related tasks to 1.35 and marking as Stalled.

CCicalese_WMF edited parent tasks, added: T232854: Expand the set of bundled extensions and skins in MediaWiki 1.35; removed: T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34.Sep 17 2019, 2:18 PM

CCicalese_WMF mentioned this in T232854: Expand the set of bundled extensions and skins in MediaWiki 1.35.

Krinkle moved this task from Blocker to Bundling on the MW-1.35-release board.Oct 11 2019, 10:45 PM

Change 565045 had a related patch set uploaded (by Legoktm; owner: Jack Phoenix):
[mediawiki/extensions/Echo@master] PostgreSQL support

https://gerrit.wikimedia.org/r/565045

gerritbot added a project: Patch-For-Review.Jan 21 2020, 7:04 AM

TheSandDoctor added a subscriber: TheSandDoctor.Jan 27 2020, 3:48 PM

Jdforrester-WMF mentioned this in T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36.Feb 27 2020, 9:15 PM

Akuckartz awarded a token.Jun 14 2020, 3:43 PM

Akuckartz added a subscriber: Akuckartz.

I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(

Jdforrester-WMF edited projects, added MW-1.36-release; removed MW-1.35-release.Jul 8 2020, 10:09 AM

Jdforrester-WMF edited parent tasks, added: T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36; removed: T232854: Expand the set of bundled extensions and skins in MediaWiki 1.35.

In T191738#6288643, @Jdforrester-WMF wrote:

I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(

Why is that a dependency? CentralAuth is not bundled; if Echo works in Postgres as part of the bundle but doesn't work when random extension X is also added to the bundle, that should not be a blocker IMO.

In T191738#6288738, @Tgr wrote:

In T191738#6288643, @Jdforrester-WMF wrote:

I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(

Why is that a dependency? CentralAuth is not bundled; if Echo works in Postgres as part of the bundle but doesn't work when random extension X is also added to the bundle, that should not be a blocker IMO.

If you want to write a set of config in CI that knows to pull the CentralAuth dependency from Notifications but only when running the postgresql DB back-end, and convince RelEng to allow that complexity into their stack, be my guest.

Legoktm moved this task from Blocker to Bundling on the MW-1.36-release board.Jul 15 2020, 4:30 AM

Reedy changed the status of subtask T244898: Notifications ('Echo') should work with postgres from Open to Stalled.Jul 31 2020, 5:18 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM

Jdforrester-WMF mentioned this in T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.Apr 10 2021, 10:47 PM

Jdforrester-WMF added a parent task: T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.

Jdforrester-WMF removed a parent task: T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36.Apr 10 2021, 10:49 PM

Jdforrester-WMF edited projects, added MW-1.37-release; removed MW-1.36-release.Apr 10 2021, 10:54 PM

Jdforrester-WMF moved this task from Blocker to Bundling on the MW-1.37-release board.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM

Aklapper removed a project: Collaboration-Team-Triage.May 25 2021, 9:09 PM

Hey there. This task is proposed as a blocker to MediaWiki 1.37, which will be cut in less than three weeks' time. Please consider whether this will make that deadline, and if not, move it to block the MediaWiki 1.38 release (MW-1.38-release) or remove as a blocker entirely.

Tgr mentioned this in T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Sep 14 2021, 12:19 AM

Tgr edited projects, added MW-1.38-release; removed MW-1.37-release.Sep 14 2021, 12:29 AM

Tgr added a parent task: T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Sep 14 2021, 12:30 AM

Tgr moved this task from Blocker to Bundling on the MW-1.38-release board.Sep 14 2021, 5:30 AM

Jdforrester-WMF mentioned this in T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.Mar 30 2022, 3:14 PM

Jdforrester-WMF added a parent task: T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.Mar 30 2022, 3:17 PM

Jdforrester-WMF edited projects, added MW-1.39-release; removed MW-1.38-release.

Jdforrester-WMF moved this task from Blocker to Bundling on the MW-1.39-release board.

Jdforrester-WMF removed a parent task: T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Mar 30 2022, 3:20 PM

Echo now contains a postgres schema (added with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/805482), please revisit if it could be bundled with the next release

Umherirrender removed a subscriber: Umherirrender.Aug 31 2022, 8:01 PM

Reedy added a parent task: T317146: Expand the set of bundled extensions and skins in MediaWiki 1.40.Sep 7 2022, 1:17 AM

Reedy mentioned this in T317146: Expand the set of bundled extensions and skins in MediaWiki 1.40.

MGChecker changed the status of subtask T244898: Notifications ('Echo') should work with postgres from Stalled to Open.Sep 7 2022, 1:20 AM

Jdforrester-WMF removed a parent task: T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.Sep 8 2022, 3:58 PM

Reedy edited projects, added MW-1.40-release; removed MW-1.39-release.Sep 25 2022, 4:50 PM

Reedy moved this task from Blocker to Bundling on the MW-1.40-release board.Sep 25 2022, 4:51 PM

Izno removed a parent task: T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.Dec 28 2022, 10:00 PM

Jdforrester-WMF closed subtask T244898: Notifications ('Echo') should work with postgres as Resolved.Feb 7 2023, 9:28 PM

Jdforrester-WMF updated the task description. (Show Details)

jforrester opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/10

Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle