- Passed security review or already Wikimedia deployed
- Voting CI structure tests
- Runs MediaWiki-CodeSniffer
- Runs phan
- Supports MySQL, SQLite, and Postgres (if there are schema changes)
- GPL v2 or later compatible license
- Extension's default configuration provides optimal experience
- Tested with web installer
Description
Details
Reference | Source Branch | Dest Branch | Author | Title | |
---|---|---|---|---|---|
repos/releng/release!10 | tarball-echo-plus | master | jforrester | Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T317146 Expand the set of bundled extensions and skins in MediaWiki 1.40 | |||
Resolved | Jdforrester-WMF | T191746 Bundle LoginNotify extension with MediaWiki | |||
Resolved | Jdforrester-WMF | T191739 Bundle Thanks extension with MediaWiki | |||
Resolved | Jdforrester-WMF | T191738 Bundle Echo extension with MediaWiki | |||
Resolved | demon | T186456 PHP Fatal error: Call to undefined method PEAR::encodeHeader() when Echo is enabled | |||
Resolved | Umherirrender | T244898 Notifications ('Echo') should work with postgres | |||
Resolved | None | T244899 CentralAuth should work with postgres | |||
Resolved | Umherirrender | T259376 Migrate CentralAuth to Abstract Schema | |||
Resolved | Umherirrender | T300576 Standardise type for timestamp columns in CentralAuth extension | |||
Resolved | Jdforrester-WMF | T259375 Migrate Echo to Abstract Schema | |||
Resolved | Umherirrender | T306473 Drop foreign keys from echo table echo_push_subscription | |||
Resolved | Legoktm | T31134 installer breaks when extensions depend on each other |
Event Timeline
I think sqlite and mysql are good. Postgres if it works, is more by accident (ie the sql works there too) than any sort of planning
It almost certainly doesn't work then, since for example the syntax for defining auto-incrementing ID fields is different, PG doesn't have "unsigned", and other incompatibilities.
It might work if someone were to write the schema for it and wire it into EchoHooks::onLoadExtensionSchemaUpdates(). MediaWiki's DQL and DML abstractions are pretty good if used right, it's just the DDL that's almost completely not abstracted.
Based on the determination above, and that clearly we are not going to get DB schemata written, tested, and merged in the next 11 days when there are no volunteers who care about PG support around, I'm moving this and related tasks to 1.35 and marking as Stalled.
Change 565045 had a related patch set uploaded (by Legoktm; owner: Jack Phoenix):
[mediawiki/extensions/Echo@master] PostgreSQL support
I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(
Why is that a dependency? CentralAuth is not bundled; if Echo works in Postgres as part of the bundle but doesn't work when random extension X is also added to the bundle, that should not be a blocker IMO.
If you want to write a set of config in CI that knows to pull the CentralAuth dependency from Notifications but only when running the postgresql DB back-end, and convince RelEng to allow that complexity into their stack, be my guest.
Hey there. This task is proposed as a blocker to MediaWiki 1.37, which will be cut in less than three weeks' time. Please consider whether this will make that deadline, and if not, move it to block the MediaWiki 1.38 release (MW-1.38-release) or remove as a blocker entirely.
Echo now contains a postgres schema (added with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/805482), please revisit if it could be bundled with the next release
jforrester opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/10
Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle
jforrester merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/10
Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle