Page MenuHomePhabricator

Bundle Echo extension with MediaWiki
Closed, ResolvedPublic

Description

  • Passed security review or already Wikimedia deployed
  • Voting CI structure tests
  • Runs MediaWiki-CodeSniffer
  • Runs phan
  • Supports MySQL, SQLite, and Postgres (if there are schema changes)
  • GPL v2 or later compatible license
  • Extension's default configuration provides optimal experience
  • Tested with web installer

Details

ReferenceSource BranchDest BranchAuthorTitle
repos/releng/release!10tarball-echo-plusmasterjforresterAdd Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle
Customize query in GitLab

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

License is MIT which is compatible with GPL 2+.

CCicalese_WMF renamed this task from Bundle Echo extension with MW 1.32 to Bundle Echo extension with MediaWiki.Nov 10 2018, 6:49 PM

What is the situation with respect to database support?

@Anomie, do you have any insight into the database support in Echo?

@Anomie, do you have any insight into the database support in Echo?

I think sqlite and mysql are good. Postgres if it works, is more by accident (ie the sql works there too) than any sort of planning

Postgres if it works, is more by accident (ie the sql works there too) than any sort of planning

It almost certainly doesn't work then, since for example the syntax for defining auto-incrementing ID fields is different, PG doesn't have "unsigned", and other incompatibilities.

It might work if someone were to write the schema for it and wire it into EchoHooks::onLoadExtensionSchemaUpdates(). MediaWiki's DQL and DML abstractions are pretty good if used right, it's just the DDL that's almost completely not abstracted.

Jdforrester-WMF changed the task status from Open to Stalled.Sep 17 2019, 2:15 PM
Jdforrester-WMF edited projects, added MW-1.35-release; removed MW-1.34-release.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Based on the determination above, and that clearly we are not going to get DB schemata written, tested, and merged in the next 11 days when there are no volunteers who care about PG support around, I'm moving this and related tasks to 1.35 and marking as Stalled.

Change 565045 had a related patch set uploaded (by Legoktm; owner: Jack Phoenix):
[mediawiki/extensions/Echo@master] PostgreSQL support

https://gerrit.wikimedia.org/r/565045

I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(

I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(

Why is that a dependency? CentralAuth is not bundled; if Echo works in Postgres as part of the bundle but doesn't work when random extension X is also added to the bundle, that should not be a blocker IMO.

I seriously doubt anyone is going to fix CentralAuth to work with postgres any time soon. :-(

Why is that a dependency? CentralAuth is not bundled; if Echo works in Postgres as part of the bundle but doesn't work when random extension X is also added to the bundle, that should not be a blocker IMO.

If you want to write a set of config in CI that knows to pull the CentralAuth dependency from Notifications but only when running the postgresql DB back-end, and convince RelEng to allow that complexity into their stack, be my guest.

Hey there. This task is proposed as a blocker to MediaWiki 1.37, which will be cut in less than three weeks' time. Please consider whether this will make that deadline, and if not, move it to block the MediaWiki 1.38 release (MW-1.38-release) or remove as a blocker entirely.

Umherirrender changed the task status from Stalled to Open.Jul 13 2022, 7:05 PM
Umherirrender added a subscriber: Umherirrender.

Echo now contains a postgres schema (added with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/805482), please revisit if it could be bundled with the next release

jforrester opened https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/10

Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle

jforrester merged https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/10

Add Echo, LoginNotfiy, and Thanks to the default MediaWiki bundle