Page MenuHomePhabricator

Bundle AbuseFilter extension with MediaWiki
Open, Needs TriagePublic

Description

  • Passed security review or already Wikimedia deployed
  • Voting CI structure tests
  • Runs MediaWiki-CodeSniffer
  • Runs phan
  • Supports MySQL, SQLite, and Postgres (if there are schema changes)
  • GPL v2 or later compatible license
  • Extension's default configuration provides optimal experience
  • Tested with web installer

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2018, 6:25 PM
Tgr added a subscriber: Tgr.Apr 8 2018, 8:56 PM
Legoktm updated the task description. (Show Details)Apr 9 2018, 2:24 AM

Change 424867 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/AbuseFilter@master] Add default rights config

https://gerrit.wikimedia.org/r/424867

Change 424867 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add default rights config

https://gerrit.wikimedia.org/r/424867

Daimona updated the task description. (Show Details)Apr 24 2018, 4:24 PM
Daimona added a subscriber: Daimona.

SQLite and Postgre support is not full, see subtasks for missing stuff.

Legoktm updated the task description. (Show Details)
Daimona updated the task description. (Show Details)Jul 16 2018, 12:17 PM

I guess "Extension's default configuration provides optimal experience" is satisfied, but is there a specific requirement list for it? Also, same question for "Tested with web installer".

Legoktm added a subscriber: Legoktm.Sep 2 2018, 8:04 PM

I guess "Extension's default configuration provides optimal experience" is satisfied, but is there a specific requirement list for it?

Just that the majority of wiki sysadmins will not need to change any of the defaults after installing.

Also, same question for "Tested with web installer".

Run through the web installer, installing MediaWiki+AbuseFilter, and then do a basic test that everything works as expected.

Looking at WMF config, these are my thoughts about default configuration:

  1. Regarding available actions (AbuseFilterActions), I think we should remove blockautopromote (unused), while 'block' can probably be left in place.
  2. We need to decide whether AF major rights (modify, viewprivate, log-detail ...) should be assigned to sysops or to a dedicated group. I think for WMF wiki the preferred option is to give all these rights to sysops only.
  3. We need to decide who to assign basic rights (abusefilter-view, abusefilter-log). I think the most used configs are to give them either to everyone ('*') or autoconfirmed.
  4. Profiling should be enabled by default, as soon as https://gerrit.wikimedia.org/r/#/c/201104/ is merged
  5. Maybe a default should be specified for AbuseFilterNotifications (rc?), while AbuseFilterNotificationsPrivate should probably be left false

Discussing the points above should be enough to make the default configuration optimal.

Daimona moved this task from Backlog to Future on the User-Daimona board.
Daimona updated the task description. (Show Details)Oct 20 2018, 10:07 AM

Works with web installer. The DB part is dependent on several tasks, so it won't probably be completed too soon. As for the user rights, I'm adding to my comment above the fact that "abusefilter-modify-restricted" has to be assigned by default: the default config has "dangerous" actions enabled and categorized as restricted, but the right is unassigned, so no-one can edit filters with such actions. Giving it to sysop would be the natural solution.

Change 468696 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Rearrange config to provide better experience

https://gerrit.wikimedia.org/r/468696

CCicalese_WMF renamed this task from Bundle AbuseFilter extension with MW 1.32 to Bundle AbuseFilter extension with MediaWiki.Nov 10 2018, 6:49 PM
Daimona moved this task from Future to Under review on the User-Daimona board.Jan 25 2019, 2:39 PM

Change 468696 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Rearrange config to provide better experience

https://gerrit.wikimedia.org/r/468696

Change 530349 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.34.0-wmf.17] Rearrange config to provide better experience

https://gerrit.wikimedia.org/r/530349

Change 530349 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@wmf/1.34.0-wmf.17] Rearrange config to provide better experience

https://gerrit.wikimedia.org/r/530349

Mentioned in SAL (#wikimedia-operations) [2019-08-15T12:14:47Z] <urbanecm@deploy1001> Synchronized wmf-config/: SWAT: 7e95f6d: Update AbuseFilter config to keep the status quo (T191740, T200032, T226987) (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2019-08-15T12:16:18Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.17/extensions/AbuseFilter/extension.json: SWAT: e9422c5: Rearrange config to provide better experience (T191740, T200032, T226987) (duration: 00m 47s)

Daimona updated the task description. (Show Details)Thu, Aug 15, 12:27 PM

Change 468696 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Rearrange config to provide better experience

https://gerrit.wikimedia.org/r/468696