In T189954#4098812, @awight wrote:It's hard to comment in GH, so I'll put some notes here:
- https://github.com/wiki-ai/ores-support-checklist/blob/master/updater.sh#L1 Hardcoded paths are bad news.
- https://github.com/wiki-ai/ores-support-checklist/blob/master/data_updater.py#L12 You could use halfak/deep-merge
- https://github.com/wiki-ai/ores-support-checklist/blob/master/data_updater.py#L19 Should clean up the hardcoded URL.
- https://github.com/wiki-ai/ores-support-checklist/blob/master/app.py#L36 Slightly more clear to call it JSON_PATH
- https://github.com/wiki-ai/ores-support-checklist/blob/master/templates/index.html I love the template! Two things to follow up on, * the "if" statements for each cell should have linebreaks, and * ampersands must be escaped as entities, even in literal URLs.
- data.json should have linebreaks. Python will output pretty JSON with json.dumps(data, indent=4)
This task is done when these are addressed.