Page MenuHomePhabricator
Create Task
Maniphest T191811

Add MediaWiki Codesniffer to Variables extension
Closed, ResolvedPublic
Actions

Description

I think Variables should be compatible with the MediaWiki coding standards in points where it isn't too much of an effort to fulfill them.

Details

SubjectRepoBranchLines +/-
Add and run MediaWiki-Codesniffermediawiki/extensions/Variablesmaster+157 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

MGChecker created this task.Apr 9 2018, 4:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2018, 4:26 PM
MGChecker triaged this task as Medium priority.Apr 9 2018, 4:27 PM
MGChecker added a subtask: T191812: Allow configuring MediaWiki.NamingConventions.ValidGlobalName.wgPrefix to allow additional prefixes.
Legoktm closed subtask T191812: Allow configuring MediaWiki.NamingConventions.ValidGlobalName.wgPrefix to allow additional prefixes as Resolved.Jul 26 2018, 3:18 AM
gerritbot subscribed.Aug 9 2018, 12:16 AM

Change 451533 had a related patch set uploaded (by MGChecker; owner: MGChecker):
[mediawiki/extensions/Variables@master] [WIP] Add and run MediaWiki-Codesniffer

https://gerrit.wikimedia.org/r/451533

gerritbot added a project: Patch-For-Review.Aug 9 2018, 12:16 AM
MGChecker added a project: MediaWiki-Codesniffer.Aug 13 2018, 2:35 PM

This task is now waiting for review.

MGChecker moved this task from Untriaged to Pass codesniffer on the MediaWiki-Codesniffer board.Aug 13 2018, 2:35 PM
MGChecker moved this task from Backlog to Maintenance on the MediaWiki-extensions-Variables board.Aug 19 2018, 10:20 PM
gerritbot added a comment.Aug 24 2018, 10:03 AM

Change 451533 merged by jenkins-bot:
[mediawiki/extensions/Variables@master] Add and run MediaWiki-Codesniffer

https://gerrit.wikimedia.org/r/451533

MGChecker closed this task as Resolved.Aug 24 2018, 3:59 PM
MGChecker removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL