Page MenuHomePhabricator
Create Task
Maniphest T191817

Copy for messaging and webstore
Closed, ResolvedPublic
Actions

Description

NOTE: Copy doc available here: https://docs.google.com/document/d/1UJKHjE40uD6UtxUijYYJBLOd_Dw1J6Zoqjh1zadHAkQ/edit?usp=sharing

Create copy for strings in the browser extension as well as webstore copy.

Messages not yet present in Extension:ReadingLists that are needed to support a reading list client:

  • A success message (e.g., "Page added!")
  • A reading lists-specific login required message (e.g., "You must be logged in to access your reading lists.")
  • (optional) An introductory clause to precede an API error message (e.g., "Failed to add page:")

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
More string resources for the browser extensionmediawiki/extensions/ReadingListsmaster+6 -2
Add i18n messages for the browser extensionmediawiki/extensions/ReadingListsmaster+14 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmadeo created this task.Apr 9 2018, 4:56 PM
• Mholloway removed • Mholloway as the assignee of this task.Apr 9 2018, 9:17 PM
• Mholloway merged a task: T191846: Localization messages for Add to Reading List browser extension.Apr 9 2018, 9:43 PM
• Mholloway updated the task description. (Show Details)
• Mholloway triaged this task as High priority.Apr 9 2018, 9:46 PM
cmadeo updated the task description. (Show Details)Apr 9 2018, 11:27 PM
• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).Apr 11 2018, 5:19 PM
• Mholloway moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.
cmadeo added a comment.Apr 17 2018, 11:37 PM

Should we start to select final copy in the copy doc?

• Mholloway added a comment.Apr 18 2018, 1:17 PM

@cmadeo Yes, let's do that. To be clear, we don't need copy for any of the "failure messages" at this point, except for (a) one to handle the case where the user has not yet chosen to enable reading list syncing, and (b) one to handle the case where the user has reached the per-list limit of 500 articles on the default list. It's not clear whether we will offer users the option of enabling directly from the extension or not in the case where syncing isn't yet enabled; that will depend on the opinion of Legal. The rest of the failures cases on the doc are impossible to encounter in the browser extension.

• Mholloway mentioned this in T191846: Localization messages for Add to Reading List browser extension.Apr 18 2018, 4:41 PM
• Mholloway added a parent task: T191846: Localization messages for Add to Reading List browser extension.Apr 18 2018, 4:44 PM
RHo added a comment.Apr 18 2018, 5:01 PM

thanks @cmadeo ! Just put in my votes with emoji (leaving rows with only one option empty).

cmadeo added a comment.Apr 18 2018, 5:08 PM

Awesome! Thanks @RHo!

gerritbot subscribed.Apr 19 2018, 3:02 PM

Change 427678 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/ReadingLists@master] Add i18n messages for the browser extension

https://gerrit.wikimedia.org/r/427678

gerritbot added a project: Patch-For-Review.Apr 19 2018, 3:02 PM
• Mholloway mentioned this in rERLS76370ee2deb4: Add i18n messages for the browser extension.Apr 19 2018, 3:06 PM
• Mholloway mentioned this in rERLS214eafc37b95: Add i18n messages for the browser extension.Apr 19 2018, 4:49 PM
• Mholloway mentioned this in rERLS8efdb5f77960: Add i18n messages for the browser extension.Apr 19 2018, 7:47 PM
gerritbot added a comment.Apr 19 2018, 9:01 PM

Change 427678 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Add i18n messages for the browser extension

https://gerrit.wikimedia.org/r/427678

RHo added a comment.Apr 19 2018, 10:31 PM

hey @Mholloway @cmadeo - may I suggest a max-width of 320px ?

Example article with a long name if max-width is set to 320px:

image.png (418×1 px, 73 KB)

Example log in prompt (min-width:160px; width:max-content):

image.png (322×496 px, 31 KB)

Changes made in this branch – LMK what you both think:
https://github.com/reetssydney/webextension-readinglists/tree/visual-tweaks-take-2

cmadeo added a comment.Apr 19 2018, 11:36 PM

@RHo LGTM! Thanks!

• Mholloway added a comment.Apr 23 2018, 10:20 PM

@RHo LGTM!

• Mholloway added a parent task: T193090: Publish WebExtension to Chrome and Firefox extension stores when complete.Apr 25 2018, 9:00 PM
LGoto added a comment.May 9 2018, 9:02 PM

Hi @cmadeo just checking, is this ready to go?

cmadeo added a comment.May 9 2018, 10:11 PM

@LGoto, everything is moved over to final in the CopyDoc so I think this is good to go

LGoto assigned this task to • Mholloway.May 9 2018, 10:20 PM

Thanks @cmadeo !

@Mholloway over to you, I think.

gerritbot added a comment.May 10 2018, 2:53 PM

Change 432386 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/ReadingLists@master] More string resources for the browser extension

https://gerrit.wikimedia.org/r/432386

• Mholloway mentioned this in rERLS5f02eb3eccab: More string resources for the browser extension.May 10 2018, 2:54 PM
• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.May 10 2018, 2:54 PM
• Mholloway moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot added a comment.May 10 2018, 8:35 PM

Change 432386 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] More string resources for the browser extension

https://gerrit.wikimedia.org/r/432386

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 10 2018, 9:00 PM
• Mholloway moved this task from Doing to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.May 14 2018, 6:37 PM
• Mholloway closed this task as Resolved.May 22 2018, 3:45 PM

Calling this resolved. The next step is publication which is covered in T193090: Publish WebExtension to Chrome and Firefox extension stores when complete.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits