Page MenuHomePhabricator
Create Task
Maniphest T191818

Linear context mixins break nested widgets
Closed, ResolvedPublic
Actions

Description

image.png (342×422 px, 19 KB)

We should use sub-widgets instead of mixins for the title icon/text.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (9c0b07868)mediawiki/extensions/VisualEditormaster+1 -3
Replace LinearContextItem mixins with sub-widgetsVisualEditor/VisualEditormaster+17 -26
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 9 2018, 4:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2018, 4:57 PM
gerritbot subscribed.Apr 9 2018, 5:13 PM

Change 425097 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Replace LinearContextItem mixins with sub-widgets

https://gerrit.wikimedia.org/r/425097

gerritbot added a project: Patch-For-Review.Apr 9 2018, 5:13 PM
Esanders claimed this task.Apr 9 2018, 5:13 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Apr 9 2018, 11:18 PM

Change 425097 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Replace LinearContextItem mixins with sub-widgets

https://gerrit.wikimedia.org/r/425097

gerritbot added a comment.Apr 10 2018, 6:08 PM

Change 425328 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (66dfb2259)

https://gerrit.wikimedia.org/r/425328

gerritbot added a comment.Apr 11 2018, 8:07 PM

Change 425328 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (9c0b07868)

https://gerrit.wikimedia.org/r/425328

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 11 2018, 9:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 13 2018, 5:34 PM
Jdforrester-WMF removed a project: Patch-For-Review.
• Deskana closed this task as Resolved.Apr 16 2018, 2:05 PM
• Deskana triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL