Page MenuHomePhabricator
Create Task
Maniphest T191823

No toolbar on mobile views using Firefox and Chromium
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Trizek-WMF
Apr 9 2018, 5:53 PM
Tags
Referenced Files
F28605780: image.png
Apr 10 2019, 10:12 PM
F28605727: image.png
Apr 10 2019, 10:12 PM
F28605733: image.png
Apr 10 2019, 10:12 PM
F28605744: image.png
Apr 10 2019, 10:12 PM
F28605754: image.png
Apr 10 2019, 10:12 PM
F28605751: image.png
Apr 10 2019, 10:12 PM
F28605747: image.png
Apr 10 2019, 10:12 PM
F16868253: Capture d’écran_2018-04-09_19-50-13.png
Apr 9 2018, 5:53 PM
View All 9 Files
Subscribers
Aklapper
• Deskana
Esanders
JTannerWMF
matmarex
Trizek-WMF
• Whatamidoing-WMF

Description

I have no toolbar on mobile views on all my browsers.
I'm on Ubuntu 16.04 LTS.

I've tested mobile editing links:

On:

While:

  • logged-in
  • logged-out

Results

  • All tests don't provide any toolbar.
  • #/editor/0 don't load the whole article, but only the first section

Result for #/editor/0 (Chromium)

Capture d’écran_2018-04-09_19-50-13.png (904×1 px, 133 KB)

Result for &action=edit (Chromium)
Capture d’écran_2018-04-09_19-49-45.png (907×1 px, 181 KB)

Related Objects

Event Timeline

Trizek-WMF created this task.Apr 9 2018, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2018, 5:53 PM
Trizek-WMF updated the task description. (Show Details)Apr 9 2018, 5:54 PM
• Deskana subscribed.Apr 11 2018, 9:46 AM

I don't think there's ever been a toolbar there. I have a few screenshots of the mobile wikitext editor from a few months ago, and there was no toolbar. Is this a feature request to add one?

Esanders subscribed.Apr 12 2018, 2:07 PM

Yeah - that is the noJS mobile editor.

If you use desktop minerva, you will see it working fine with WikiEditor toolbar: https://en.wikipedia.org/w/index.php?title=I_Will_Always_Love_You&action=submit&useskin=minerva

Trizek-WMF added a comment.Apr 12 2018, 2:11 PM

I've accessed that editor by the link located at the bottom of every page...

Esanders added a comment.Apr 16 2018, 3:03 PM

Which link? Do you mean 'Mobile view' while already in the editor?

Trizek-WMF added a comment.EditedApr 16 2018, 3:06 PM

Case 1:

  1. visit a page
  2. click on Mobile view
  3. edit the page (pen icon)

Result: no editor, and the ful page is not leading

Case 2:

  1. visit a page
  2. click edit
  3. click on Mobile view
  4. edit the page (pen icon)

Result: no editor, and the ful page is not leading

Tested both while logged-in and logged-out (private mode).

Esanders added a comment.Apr 16 2018, 6:03 PM
In T191823#4133872, @Trizek-WMF wrote:

Case 1:

  1. visit a page
  2. click on Mobile view
  3. edit the page (pen icon)

Result: no editor, and the ful page is not leading

I can't reproduce this - the MobileFrontend editor loads for me. Do you get any exceptions in the console?

Esanders edited projects, added MobileFrontend; removed Browser-Support-Google-Chrome, Browser-Support-Firefox.Apr 16 2018, 6:03 PM
Trizek-WMF added a comment.EditedApr 18 2018, 9:24 AM

While switching to mobile, logged-in:

VM211:1 Uncaught ReferenceError: obtenir is not defined
    at <anonymous>:1:120
    at DOMEval (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:1)
    at Function.globalEval (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:4)
    at runScript (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:162)
    at fire (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:46)
    at Object.add [as fail] (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:47)
    at Object.always (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:48)
    at checkCssHandles (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:162)
    at execute (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:163)
    at Object.implement (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:169)

While editing the page on mobile view, logged out:

load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:154 Use of "done" is deprecated. Use Promise compatible methods `then` and `catch` instead.
get @ load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:154
_loadContent @ load.php?debug=false&lang=fr&modules=mediawiki.confirmCloseWindow%2Cnotification%2CvisibleTimeout|mediawiki.editfont.styles|mobile.editor.common%2Coverlay|mobile.messageBox|mobile.messageBox.styles|oojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows|oojs-ui-core.styles|oojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures&skin=minerva&version=0qe8hj5:34
_showEditorAfterWarning @ load.php?debug=false&lang=fr&modules=mediawiki.confirmCloseWindow%2Cnotification%2CvisibleTimeout|mediawiki.editfont.styles|mobile.editor.common%2Coverlay|mobile.messageBox|mobile.messageBox.styles|oojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows|oojs-ui-core.styles|oojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures&skin=minerva&version=0qe8hj5:32
onClickContinue @ load.php?debug=false&lang=fr&modules=mediawiki.confirmCloseWindow%2Cnotification%2CvisibleTimeout|mediawiki.editfont.styles|mobile.editor.common%2Coverlay|mobile.messageBox|mobile.messageBox.styles|oojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows|oojs-ui-core.styles|oojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures&skin=minerva&version=0qe8hj5:29
dispatch @ load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:69
elemData.handle @ load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:66
load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:154 Use of "fail" is deprecated. Use Promise compatible methods `then` and `catch` instead.
get @ load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:154
_loadContent @ load.php?debug=false&lang=fr&modules=mediawiki.confirmCloseWindow%2Cnotification%2CvisibleTimeout|mediawiki.editfont.styles|mobile.editor.common%2Coverlay|mobile.messageBox|mobile.messageBox.styles|oojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows|oojs-ui-core.styles|oojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures&skin=minerva&version=0qe8hj5:34
_showEditorAfterWarning @ load.php?debug=false&lang=fr&modules=mediawiki.confirmCloseWindow%2Cnotification%2CvisibleTimeout|mediawiki.editfont.styles|mobile.editor.common%2Coverlay|mobile.messageBox|mobile.messageBox.styles|oojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows|oojs-ui-core.styles|oojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures&skin=minerva&version=0qe8hj5:32
onClickContinue @ load.php?debug=false&lang=fr&modules=mediawiki.confirmCloseWindow%2Cnotification%2CvisibleTimeout|mediawiki.editfont.styles|mobile.editor.common%2Coverlay|mobile.messageBox|mobile.messageBox.styles|oojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows|oojs-ui-core.styles|oojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-interactions%2Cicons-moderation%2Cicons-movement%2Cindicators%2Ctextures&skin=minerva&version=0qe8hj5:29
dispatch @ load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:69
elemData.handle @ load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=032b6rt:66
Esanders added a comment.Sep 5 2018, 4:50 PM

Is this still happening?

Trizek-WMF added a comment.Sep 5 2018, 4:51 PM
In T191823#4560147, @Esanders wrote:

Is this still happening?

Yes.

Esanders added a comment.Sep 5 2018, 5:39 PM

Looking at your screenshots, it looks like everything wass working as expected. /editor/0 is supposed to only load the first section, and currently action=edit is loading the new editor/all path in the mobile editor.

Trizek-WMF added a comment.Sep 6 2018, 12:38 PM

If it was working as expected, I would get toolbars. :)

Esanders added a comment.Apr 2 2019, 2:17 PM

The second link is redirecting to the MobileFrontend or VE editor for me (whichever was used last). Can you confirm this is fixed?

Trizek-WMF added a comment.Apr 3 2019, 5:46 PM

https://en.m.wikipedia.org/w/index.php?title=I_Will_Always_Love_You&action=edit redirects to https://en.m.wikipedia.org/w/index.php?title=I_Will_Always_Love_You#/editor/all

Esanders added a comment.EditedApr 9 2019, 3:30 PM

So... yes? I see an editing toolbar.

matmarex subscribed.Apr 10 2019, 10:12 PM

These are the interfaces you should see (when using any edit link):

When you're using the mobile site:

Reading modeWikitext editorVisual editor
image.png (980×1 px, 308 KB)
image.png (980×1 px, 90 KB)
image.png (980×1 px, 77 KB)

The mobile site reading mode has collapsible sections. Both mobile editors are full-screen (the menu bar is hidden). Mobile wikitext editor is completely different from both the old and new desktop wikitext editors. Mobile visual editor has reduced number of tools on the toolbar.

When you're using the desktop site:

Reading modeOld wikitext editorNew wikitext editorVisual editor
image.png (980×1 px, 312 KB)
image.png (980×1 px, 130 KB)
image.png (980×1 px, 137 KB)
image.png (980×1 px, 286 KB)

The desktop site reading mode in the Minerva skin doesn't have collapsible sections. The desktop editors in the Minerva skin are not full-screen (the menu bar is shown above them). Desktop visual editor in the Minerva skin has all the tools you'd see on Vector.

Note that the interface you see doesn't depend on whether you're using a browser on a mobile or desktop device – only on whether you're looking at the mobile or desktop site (https://en.m.wikipedia.org/ vs https://en.wikipedia.org/).

Does this match what you're seeing? If not, can you take a screenshot and attach it?

JTannerWMF subscribed.Apr 23 2019, 3:56 PM

Hey @Trizek-WMF we just need you to respond to what you believe should be happening.

JTannerWMF moved this task from To Triage to Blocked on the VisualEditor board.Apr 23 2019, 3:56 PM
Jdlrobson moved this task from Backlog to Team:Editing on the MobileFrontend board.Jul 24 2020, 2:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL