Page MenuHomePhabricator
Create Task
Maniphest T191858

"Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly)
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Etonkovidova
Apr 9 2018, 11:21 PM
Tags
Referenced Files
F32353953: image.png
Sep 17 2020, 10:13 PM
F32353957: image.png
Sep 17 2020, 10:13 PM
F32353951: image.png
Sep 17 2020, 10:13 PM
F32353955: image.png
Sep 17 2020, 10:13 PM
F16901873: Screen Shot 2018-04-10 at 19.45.49.png
Apr 10 2018, 6:47 PM
F16886368: Screen Shot 2018-04-09 at 2.03.51 PM.png
Apr 10 2018, 12:07 AM
Subscribers
Aklapper
• Deskana
Esanders
Etonkovidova
Jdlrobson
matmarex

Description

Insert the following table (found in https://en.wikipedia.org/wiki/Timeline_of_the_Apple_II_family

{| class="wikitable"
| style="width:40px;vertical-align:top" rowspan="4" |'''1977''' || style="width:100px" rowspan="4"| April 16 || style="width:230px" | [[Apple II]] || style="width:110px" | [[Apple II]] || style="width:130px" | January 1, 1981
|-
|}

The table is saved and displayed correctly.
Open in VE and click on the first or second cell - the following Console error is displayed:

Uncaught TypeError: Cannot read property 'findParent' of undefined
    at VeDmTableSelection.ve.dm.TableSelection.isMergeable 
    at VeUiMergeCellsContextItem.ve.ui.MergeCellsContextItem.setup 
    at VeUiDesktopContext.ve.ui.Context.setupMenuItems     
    at VeUiDesktopContext.ve.ui.Context.toggleMenu 
    at VeUiDesktopContext.ve.ui.LinearContext.afterContextChange 
    at VeUiDesktopContext.ve.ui.DesktopContext.afterContextChange

Screen Shot 2018-04-09 at 2.03.51 PM.png (618×996 px, 152 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (1c3ca2da9)mediawiki/extensions/VisualEditormaster+1 -1
Handle tables with rowspans that exceed the matrixVisualEditor/VisualEditormaster+110 -8
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Apr 9 2018, 11:21 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 9 2018, 11:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova updated the task description. (Show Details)Apr 10 2018, 12:07 AM
Esanders triaged this task as Low priority.Apr 10 2018, 9:43 AM
Esanders subscribed.

That is definitely very broken table syntax, but ideally we wouldn't throw an exception.

• Deskana renamed this task from "Cannot read property 'findParent' of undefined" when editing a table to "Cannot read property 'findParent' of undefined" when editing a table (but editing the table works correctly).Apr 10 2018, 6:44 PM
• Deskana subscribed.Apr 10 2018, 6:47 PM

The table is still editable, despite this exception being thrown.

As an aside, the tables also don't display properly in read mode in Firefox. These are very bad tables.

Screen Shot 2018-04-10 at 19.45.49.png (536×1 px, 111 KB)

• Deskana moved this task from To Triage to Freezer on the VisualEditor board.Apr 10 2018, 6:48 PM
• Deskana lowered the priority of this task from Low to Lowest.Apr 11 2018, 9:56 AM

This is absolute lowest priority—it's definitely valid issue, but it doesn't affect core functionality and it only happens if someone does something really wrong with the table.

Jdlrobson added a project: Wikimedia-production-error.Aug 31 2020, 9:55 PM
Jdlrobson subscribed.Aug 31 2020, 9:58 PM

Showing up in production error logs.
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.08.31/clienterror/?id=AXRGUPmnNoG2jwpwKJmD

gerritbot added a comment.Sep 2 2020, 8:02 PM

Change 623858 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Handle tables with rowspans that exceed the matrix

https://gerrit.wikimedia.org/r/623858

gerritbot added a project: Patch-For-Review.Sep 2 2020, 8:02 PM
Esanders claimed this task.Sep 2 2020, 8:02 PM
Esanders moved this task from Freezer to Triaged on the VisualEditor board.
Esanders added a project: Editing-team (Kanban Board).
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
Jdlrobson moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 16 2020, 6:49 PM
Umherirrender added a project: JavaScript.Sep 16 2020, 7:52 PM
gerritbot added a comment.Sep 17 2020, 9:45 PM

Change 623858 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Handle tables with rowspans that exceed the matrix

https://gerrit.wikimedia.org/r/623858

gerritbot added a comment.Sep 17 2020, 9:52 PM

Change 628205 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1c3ca2da9)

https://gerrit.wikimedia.org/r/628205

gerritbot added a comment.Sep 17 2020, 10:12 PM

Change 628205 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1c3ca2da9)

https://gerrit.wikimedia.org/r/628205

matmarex edited projects, added Editing QA; removed Patch-For-Review.Sep 17 2020, 10:13 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
matmarex subscribed.

Reduced test case for QA: https://en.wikipedia.beta.wmflabs.org/wiki/T191858

{| class="wikitable"
|rowspan="3"| A
| B
| C
|}

The first cell in this table is defined to span 3 rows, but the table has only 1 row.

Before the patch, selecting the first cell immediately caused an error, and choosing (row menu) → Insert below did nothing (and caused another error). Various other table operations also failed.

After the patch, there should be no errors. There's one known issue (we're not planning to work on it): "Inserting a new row doesn't quite work as expected, because it relies on the last row in the matrix to be correctly formed, but one can use the placeholder buttons to fix the newly inserted row, and no exceptions are thrown, so this is good enough for now."

image.png (155×235 px, 2 KB) image.png (155×235 px, 2 KB) image.png (155×235 px, 4 KB) image.png (155×235 px, 4 KB)

• ppelberg moved this task from Inbox to Low Priority on the Editing QA board.Oct 1 2020, 11:03 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Oct 8 2020, 6:19 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 9 2020, 3:49 PM
JTannerWMF removed projects: Verified, JavaScript, Editing-team (Kanban Board), Wikimedia-production-error, VisualEditor-ContentEditable, VisualEditor.Oct 14 2020, 3:09 PM
JTannerWMF added projects: VisualEditor, Wikimedia-production-error, JavaScript, Editing-team (Tracking).Oct 14 2020, 3:15 PM
matmarex edited projects, added Editing-team (Kanban Board), Verified, VisualEditor-ContentEditable; removed Editing-team (Tracking).Oct 14 2020, 3:38 PM
• ppelberg closed this task as Resolved.Oct 17 2020, 12:35 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 17 2020, 12:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL