Page MenuHomePhabricator
Create Task
Maniphest T191916

Warning: Destructor threw an object exception: exception 'Wikimedia\Rdbms\DBUnexpectedError' with message 'Wikimedia\Rdbms\Database::close: Expected mass commit of all peer transactions (DBO_TRX set).' in /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/database/Database.php:3602
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Have only rolled out 1.31.0-wmf.29 to testwiki and already seeing this message at the top of logstash.

Stack trace:

#0 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/database/Database.php(924): Wikimedia\Rdbms\Database->commit()
#1 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1208): Wikimedia\Rdbms\Database->close()
#2 (): Closure$Wikimedia\Rdbms\LoadBalancer::closeAll()
#3 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1631): call_user_func_array()
#4 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1209): Wikimedia\Rdbms\LoadBalancer->forEachOpenConnection()
#5 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1199): Wikimedia\Rdbms\LoadBalancer->closeAll()
#6 (): Wikimedia\Rdbms\LoadBalancer->disable()
#7 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/lbfactory/LBFactory.php(196): call_user_func_array()
#8 (): Closure$Wikimedia\Rdbms\LBFactory::forEachLBCallMethod()
#9 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/lbfactory/LBFactoryMulti.php(425): call_user_func_array()
#10 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/lbfactory/LBFactory.php(199): Wikimedia\Rdbms\LBFactoryMulti->forEachLB()
#11 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/lbfactory/LBFactory.php(143): Wikimedia\Rdbms\LBFactory->forEachLBCallMethod()
#12 /srv/mediawiki/php-1.31.0-wmf.29/includes/libs/rdbms/lbfactory/LBFactory.php(607): Wikimedia\Rdbms\LBFactory->destroy()
#13 (): Wikimedia\Rdbms\LBFactory->__destruct()
#14 {main}

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+86 -22rdbms: fix transaction flushing in Database::close
mediawiki/corewmf/1.31.0-wmf.29+86 -22rdbms: fix transaction flushing in Database::close
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Apr 10 2018, 7:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2018, 7:54 PM
thcipriani triaged this task as Unbreak Now! priority.Apr 10 2018, 7:56 PM
thcipriani added a parent task: T183968: 1.31.0-wmf.29 deployment blockers.

Added at 1.31.0-wmf.29 blocker, setting to UBN!

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 10 2018, 7:56 PM
thcipriani added a subscriber: aaron.Apr 10 2018, 7:59 PM

Adding @aaron because it's database related

RazeSoldier updated the task description. (Show Details)Apr 11 2018, 12:08 AM
RazeSoldier updated the task description. (Show Details)Apr 11 2018, 3:48 AM
aaron added a comment.Apr 11 2018, 5:28 AM

I suspect the transactions are just empty ones with SELECT statements, which don't need to give errors here.

gerritbot added a subscriber: gerritbot.Apr 11 2018, 5:43 AM

Change 425471 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] rdbms: fix transaction flushing in Database::close

https://gerrit.wikimedia.org/r/425471

gerritbot added a project: Patch-For-Review.Apr 11 2018, 5:43 AM
Krinkle added a project: MediaWiki-libs-Rdbms.Apr 11 2018, 4:14 PM
Krinkle added a project: Performance-Team.
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
gerritbot added a comment.Apr 11 2018, 4:22 PM

Change 425471 merged by jenkins-bot:
[mediawiki/core@master] rdbms: fix transaction flushing in Database::close

https://gerrit.wikimedia.org/r/425471

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 11 2018, 5:00 PM
Krinkle added a subscriber: Krinkle.Apr 11 2018, 5:35 PM

Confirmed that the error has gone away in beta:

Screen Shot 2018-04-11 at 18.35.09.png (520×2 px, 99 KB)

gerritbot added a comment.Apr 11 2018, 5:35 PM

Change 425566 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@wmf/1.31.0-wmf.29] rdbms: fix transaction flushing in Database::close

https://gerrit.wikimedia.org/r/425566

gerritbot added a comment.Apr 11 2018, 7:06 PM

Change 425566 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.29] rdbms: fix transaction flushing in Database::close

https://gerrit.wikimedia.org/r/425566

Stashbot added a subscriber: Stashbot.Apr 11 2018, 7:09 PM

Mentioned in SAL (#wikimedia-operations) [2018-04-11T19:09:55Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.29/includes/libs/rdbms/database: [[gerrit:425566|rdbms: fix transaction flushing in Database::close]] T191916 (duration: 01m 01s)

thcipriani closed this task as Resolved.Apr 11 2018, 7:28 PM
thcipriani assigned this task to aaron.

Looks resolved in prod. Thanks for the patch @aaron !

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 11 2018, 8:00 PM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Apr 14 2018, 9:05 AM
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:33 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL