I don't see a valid reason why T152462: Add cookie when blocking anonymous users shouldn't be enabled by default for all wikis after the initial roll-out and that we know it works as intended.
$wgCookieSetOnIpBlock should be set to true by default.
$wgCookieSetOnAutoblock looks like another good candidate to enable by default.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T52039 Proposed changes to default settings (tracking) | |||
| Resolved | dmaza | T191922 Enable $wgCookieSetOnIpBlock by default after the IP cookie block feature is fully tested and released | |||
| Resolved | dmaza | T152462 Add cookie when blocking anonymous users | |||
| Invalid | dmaza | T191542 Implement event logging for IP cookie blocks to make sure it's working reasonably | |||
| Resolved | None | T192016 Release anon cookie blocking on test.wikipedia.org | |||
| Resolved | dbarratt | T192017 Enable anon cookie blocking on all Wikimedia wikis | |||
| Resolved | dmaza | T195930 Enable set cookie with IP/IP-Range blocks when blocking logged-out users | |||
| Resolved | dmaza | T196121 Enable set cookie with IP/IP-Range blocks when blocking logged-out users on itwiki |
Usually, when a task says "enable for all wikis by default", that does not relates to enabling settings in MediaWiki core. Rather, it usually means:
'wgUseTheFeature' => [ + 'default' => true, - 'default' => false, - - // group0 - 'testwiki' => true, - 'test2wiki' => true, - 'mediawikiwiki' => true, - - // Opt-in wikis - 'nlwiki' => true, - 'commonswiki' => true, - 'metawiki' => true, - - // Wiki families - 'wiktionary' => true, - 'wikipedia' => true, ],
Anyhow, I've tagged it with MW-1.32-release so that we'll remember before November 2018 to evaluate and whether to enable it for this or a later release.
I think the whole "conundrum" was weather to have this feature enabled by default in core or not. Basically, why enable by a config patch when this should(?) be a standard feature on core.
Un-stalling, it's been about a month after deploying to Wikimedia sites. Should we flip the MediaWiki defaults now?
Maybe it is a good idea to also remove the debug tracking we have in there (?)
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/user/User.php#1407
Removing the tracking (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/includes/user/User.php#1407) or flipping the switch?
I can do both
1.33.0-rc.0 has sailed... If we want this in 1.33 (and as such 1.33.0-rc.1), patches would be welcome soon...
This missed the boat for the MW 1.33 release. Provisionally re-tagging to 1.34's release instead.
Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?
Change 534690 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Enable $wgCookieSetOnAutoblock and $wgCookieSetOnIpBlock by default
@Jdforrester-WMF Since CommonSettings is currently setting these two configs to true there shouldn't be any problems I assume.
The next step would be to remove it from mediawiki-config. I could also do that after this gets deployed if you want.
Change 534690 merged by jenkins-bot:
[mediawiki/core@master] Enable $wgCookieSetOnAutoblock and $wgCookieSetOnIpBlock by default
OK, this bit is done. Thank you! I'll do a cleanup patch for after next week's train.
Change 534698 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Stop setting wgCookieSetOnAutoBlock and wgCookieSetOnIpBlock to the default; never varied
Change 534698 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop setting wgCookieSetOnAutoBlock and wgCookieSetOnIpBlock to the default; never varied