Page MenuHomePhabricator

The old tryUISubmit and the new submitForm will blissfully return Status::newGood() even when it isn't good.
Closed, ResolvedPublic

Description

I ran into this problem when preferences add by an extension would throw an input validation error and was setting $result to false in the PreferencesFormPreSave hook. Preferences would just ignore it and happily save the bad user input regardless.

https://gerrit.wikimedia.org/r/425436

Event Timeline

Alexia created this task.Apr 10 2018, 10:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2018, 10:24 PM

Change 425436 had a related patch set uploaded (by Krinkle; owner: Alexia):
[mediawiki/core@master] preferences: Preserve Status from saveFormData() in submitForm()

https://gerrit.wikimedia.org/r/425436

matmarex closed this task as Resolved.May 30 2018, 7:06 PM
matmarex assigned this task to Alexia.
matmarex removed a project: Patch-For-Review.

Change 425436 merged by jenkins-bot:
[mediawiki/core@master] preferences: Preserve Status from saveFormData() in submitForm()

https://gerrit.wikimedia.org/r/425436