Page MenuHomePhabricator
Create Task
Maniphest T191953

WDQS Container GUI constantly loads style.less
Closed, DeclinedPublic
Actions

Description

After starting the containers, if I attach to wikibasedocker_wdqs-frontend_1 container, I see log that shows that /style.less is constantly loaded:

72.18.0.1 - - [11/Apr/2018:04:50:22 +0000] "GET /style.less HTTP/1.1" 200 9443 "http://localhost:8282/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3282.94 Safari/537.36 OPR/44.0.2168.124" "-"
172.18.0.1 - - [11/Apr/2018:04:50:24 +0000] "GET /style.less HTTP/1.1" 200 9443 "http://localhost:8282/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3282.94 Safari/537.36 OPR/44.0.2168.124" "-"
172.18.0.1 - - [11/Apr/2018:04:50:25 +0000] "GET /style.less HTTP/1.1" 200 9443 "http://localhost:8282/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3282.94 Safari/537.36 OPR/44.0.2168.124" "-"
172.18.0.1 - - [11/Apr/2018:04:50:27 +0000] "GET /style.less HTTP/1.1" 200 9443 "http://localhost:8282/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3282.94 Safari/537.36 OPR/44.0.2168.124" "-"
172.18.0.1 - - [11/Apr/2018:04:50:28 +0000] "GET /style.less HTTP/1.1" 200 9443 "http://localhost:8282/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3282.94 Safari/537.36 OPR/44.0.2168.124" "-"

Looks like some kind of bug.

Related Objects
Search...

Event Timeline

Smalyshev created this task.Apr 11 2018, 4:52 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptApr 11 2018, 4:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev renamed this task from Container GUI constantly loads style.less to WDQS Container GUI constantly loads style.less.Apr 11 2018, 4:53 AM
Addshore moved this task from Backlog to Features on the Wikibase-Docker-2017+ board.Apr 11 2018, 5:12 PM
Lucas_Werkmeister_WMDE subscribed.Apr 12 2018, 9:25 AM

It’s not a bug, it’s a feature :) for local development, the style.less file is compiled in the browser and automatically reloaded when you edit the file locally, without having to reload the whole page.

But as far as I understand, the docker image is not intended for local development, so I suppose it should build the GUI and then serve the build directory?

Smalyshev added a comment.Apr 12 2018, 5:24 PM

Well, as afar as I understand, docker image is for both. But it would be hard to use built GUI there because build GUI has config.js inside minimized files and thus it is not customizeable. We then need to make it live outside (or load some other file that can be customized).

Tarrow subscribed.Apr 17 2018, 8:28 AM

Maybe we should have a 'dev' tagged version of the container that remains as it is now. The new 'vanilla' container should then serve the built build directory.

Addshore moved this task from Features to Bugs on the Wikibase-Docker-2017+ board.Apr 25 2018, 2:00 PM
Addshore triaged this task as Medium priority.Jun 26 2018, 3:57 PM
Addshore claimed this task.Nov 12 2018, 5:35 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 12 2018, 5:35 PM
Addshore removed Addshore as the assignee of this task.Nov 12 2018, 5:37 PM
Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.Jan 17 2019, 5:09 PM
Lucas_Werkmeister_WMDE added a parent task: T234041: wikibase-docker should build Query Service UI.Sep 27 2019, 1:25 PM
Addshore added a comment.Sep 27 2019, 7:13 PM
In T191953#4135392, @Tarrow wrote:

Maybe we should have a 'dev' tagged version of the container that remains as it is now. The new 'vanilla' container should then serve the built build directory.

As said above in T191953#4127694 that isn't really possible as the config is in the minified JS.
In order to have a nicedocker images some changes probably have to be made to the wdqsgui code itself.
For 3rd party users of the wdqsgui, if they want to use docker the best thing to do would be for them to build their own image with their own config included.

Addshore closed this task as Declined.Jun 21 2021, 7:24 AM

The wikibase-docker git repository will be going away

Please see the announcement for new images https://lists.wikimedia.org/hyperkitty/list/wikibaseug@lists.wikimedia.org/thread/WW4LZJINT3PIG3DOYKTXIWVP3WAKWXCT/
Along with docs https://www.mediawiki.org/wiki/Wikibase/Docker

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL