Page MenuHomePhabricator
Create Task
Maniphest T191958

When resolving a topic, clicking on the summary textarea uncollapses and collapses all messages
Closed, ResolvedPublic
Actions

Description

How to reproduce:

  1. resolve a topic - all messages are collapsed and are not visible
  2. click in the textarea field

Expectation:

  • nothing moves

Reality:

  • collapsed messages are visible
  • if you click again, they are collapsed again and so on.

Tested on Firefox and Chromium last versions.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't expand/collapse topics when clicking the editormediawiki/extensions/Flowmaster+5 -0
Customize query in gerrit

Event Timeline

Trizek-WMF created this task.Apr 11 2018, 8:10 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 11 2018, 8:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Trizek-WMF updated the task description. (Show Details)Apr 11 2018, 8:11 AM
• jmatazzoni added a project: good first task.May 3 2018, 1:33 AM
• jmatazzoni moved this task from Untriaged to Medium-Term Interest on the Collaboration-Team-Triage board.
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 10:10 AM
SBisson removed projects: good first task, Collaboration-Team-Triage.Sep 7 2018, 8:43 PM
SBisson subscribed.

It's the Flow legacy front-end we're talking about.

gerritbot subscribed.Sep 12 2018, 8:47 PM

Change 460100 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Flow@master] Don't expand/collapse topics when clicking the editor

https://gerrit.wikimedia.org/r/460100

gerritbot added a project: Patch-For-Review.Sep 12 2018, 8:47 PM
SBisson claimed this task.Sep 12 2018, 8:48 PM
SBisson edited projects, added: Growth-Team (Sprint 0 (Growth Team)); removed: Growth-Team.
SBisson moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 14 2018, 7:01 PM
kostajh subscribed.Sep 14 2018, 7:04 PM

I merged the patch, but wanted to note that it feels odd that "Summarize" shows you the list of comments while "Resolve" does not, even though both actions prompt you to add a summary via flow-edit-summary-placeholder. But that's another issue for another day.

gerritbot added a comment.Sep 14 2018, 7:30 PM

Change 460100 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Don't expand/collapse topics when clicking the editor

https://gerrit.wikimedia.org/r/460100

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 14 2018, 8:00 PM
Etonkovidova closed this task as Resolved.Sep 14 2018, 9:54 PM
Etonkovidova subscribed.

Checked the fix in betalabs.

Etonkovidova added a comment.Sep 18 2018, 9:59 PM

Checked in testwiki (wmf.22) - the issue is not present.

For comparison - in wmf.20 clicking in Summary will open posts:

Screen Shot 2018-09-18 at 2.55.45 PM.png (754×502 px, 68 KB)

Clicked again:

Screen Shot 2018-09-18 at 2.54.23 PM.png (784×490 px, 55 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits