Page MenuHomePhabricator

When resolving a topic, clicking on the summary textarea uncollapses and collapses all messages
Closed, ResolvedPublic

Description

How to reproduce:

  1. resolve a topic - all messages are collapsed and are not visible
  2. click in the textarea field

Expectation:

  • nothing moves

Reality:

  • collapsed messages are visible
  • if you click again, they are collapsed again and so on.

Tested on Firefox and Chromium last versions.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SBisson added a subscriber: SBisson.

It's the Flow legacy front-end we're talking about.

Change 460100 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Flow@master] Don't expand/collapse topics when clicking the editor

https://gerrit.wikimedia.org/r/460100

I merged the patch, but wanted to note that it feels odd that "Summarize" shows you the list of comments while "Resolve" does not, even though both actions prompt you to add a summary via flow-edit-summary-placeholder. But that's another issue for another day.

Change 460100 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Don't expand/collapse topics when clicking the editor

https://gerrit.wikimedia.org/r/460100

Etonkovidova added a subscriber: Etonkovidova.

Checked the fix in betalabs.

Checked in testwiki (wmf.22) - the issue is not present.

For comparison - in wmf.20 clicking in Summary will open posts:

Screen Shot 2018-09-18 at 2.55.45 PM.png (502×754 px, 68 KB)

Clicked again:

Screen Shot 2018-09-18 at 2.54.23 PM.png (490×784 px, 55 KB)