Maniphest T191959

ApiStructureTest::testParameterConsistency with data set #144 ('wbsgetsuggestions')
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Apr 11 2018, 8:31 AM

Description

https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-jessie/41369/console:

15:48:27 2) ApiStructureTest::testParameterConsistency with data set #144 ('wbsgetsuggestions')
15:48:27 limit: PARAM_RANGE_ENFORCE can only be used with PARAM_TYPE integer
15:48:27 Failed asserting that an array contains 'limit'.
15:48:27 
15:48:27 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/structure/ApiStructureTest.php:316
15:48:27 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:421
15:48:27 /home/jenkins/workspace/mwext-testextension-hhvm-jessie/src/maintenance/doMaintenance.php:94

This is blocking merges to at least Content Translation, so I'm asking this to be resolved with a high priority. As far as I know ApiBase::PARAM_RANGE_ENFORCE is not required for limit type.

Details

	Subject	Repo	Branch	Lines +/-
	Fix "limit: PARAM_RANGE_ENFORCE can only be used with PARAM_TYPE integer"	mediawiki/extensions/PropertySuggester	master	+0 -1

Customize query in gerrit

Related Objects

Mentioned In: rEPS8fccc6516b6a: Fix "limit: PARAM_RANGE_ENFORCE can only be used with PARAM_TYPE integer"

Event Timeline

Nikerabbit created this task.Apr 11 2018, 8:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2018, 8:31 AM

Change 425490 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/PropertySuggester@master] Fix "limit: PARAM_RANGE_ENFORCE can only be used with PARAM_TYPE integer"

https://gerrit.wikimedia.org/r/425490

gerritbot added a project: Patch-For-Review.Apr 11 2018, 8:32 AM

Nikerabbit triaged this task as Unbreak Now! priority.Apr 11 2018, 8:35 AM

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 11 2018, 8:35 AM

Change 425490 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Fix "limit: PARAM_RANGE_ENFORCE can only be used with PARAM_TYPE integer"

https://gerrit.wikimedia.org/r/425490

hoo closed this task as Resolved.Apr 11 2018, 9:29 AM

hoo claimed this task.

hoo removed a project: Patch-For-Review.

Liuxinyu970226 unsubscribed.Apr 11 2018, 9:31 AM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 11 2018, 10:01 AM

Nikerabbit mentioned this in rEPS8fccc6516b6a: Fix "limit: PARAM_RANGE_ENFORCE can only be used with PARAM_TYPE integer".May 25 2023, 6:45 PM

Maintenance_bot added a project: Wikidata.May 25 2023, 6:45 PM