Page MenuHomePhabricator
Create Task
Maniphest T191961

Investigate why interwiki cache hit/miss is no longer reported
Closed, ResolvedPublic
Actions

Description

The last time it was reported was october 9 2017.

Details

SubjectRepoBranchLines +/-
[cirrus] cleanup drop wgCirrusSearchInterwikiCacheTimeoperations/mediawiki-configmaster+0 -2
Drop support for caching interwiki queriesmediawiki/extensions/CirrusSearchmaster+0 -16
Repair interwiki query cachemediawiki/extensions/CirrusSearchmaster+52 -3
Customize query in gerrit

Event Timeline

dcausse created this task.Apr 11 2018, 9:33 AM
Restricted Application edited projects, added Discovery-ARCHIVED, Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptApr 11 2018, 9:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• EBjune triaged this task as Medium priority.Apr 26 2018, 5:22 PM
• EBjune moved this task from needs triage to Up Next on the Discovery-Search board.
EBernhardson moved this task from Up Next to Current work on the Discovery-Search board.Sep 11 2018, 5:21 PM
EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search.
EBernhardson claimed this task.Sep 13 2018, 8:25 PM
EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Sep 13 2018, 9:56 PM

Change 460445 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Repair interwiki query cache

https://gerrit.wikimedia.org/r/460445

gerritbot added a project: Patch-For-Review.Sep 13 2018, 9:56 PM
EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Sep 13 2018, 9:57 PM
EBernhardson added a comment.Sep 14 2018, 6:01 PM

It turns out the cache has been disabled. We've been running without it likely since oct 2017, does it matter to put back in place? The patch above tries to fix the cache, but we could alternatively remove it.

gerritbot added a comment.Sep 17 2018, 5:40 PM

Change 460445 abandoned by EBernhardson:
Repair interwiki query cache

Reason:
this hasn't been used for a year since it broke, agreed to delete it from the code instead.

https://gerrit.wikimedia.org/r/460445

gerritbot added a comment.Sep 17 2018, 7:43 PM

Change 460962 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Drop support for caching interwiki queries

https://gerrit.wikimedia.org/r/460962

gerritbot added a comment.Sep 18 2018, 8:22 AM

Change 461088 had a related patch set uploaded (by DCausse; owner: DCausse):
[operations/mediawiki-config@master] [cirrus] cleanup drop wgCirrusSearchInterwikiCacheTime

https://gerrit.wikimedia.org/r/461088

gerritbot added a comment.Sep 18 2018, 8:35 AM

Change 460962 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Drop support for caching interwiki queries

https://gerrit.wikimedia.org/r/460962

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 18 2018, 9:00 AM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 18 2018, 5:17 PM
gerritbot added a comment.Sep 18 2018, 11:10 PM

Change 461088 merged by jenkins-bot:
[operations/mediawiki-config@master] [cirrus] cleanup drop wgCirrusSearchInterwikiCacheTime

https://gerrit.wikimedia.org/r/461088

debt closed this task as Resolved.Oct 5 2018, 4:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL