Maniphest T192004

[Bug] [IE 11] Popups settings dialog is offcenter
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• Niedzielski
	Apr 11 2018, 5:20 PM

Description

Steps to reproduce

Open Internet Explorer 11 and visit Wikipedia
Logout
Hover over a link to a normal page, such as Barack Obama
Click the settings cog

Expected results

Settings dialog is centered

Actual results

Settings dialog is centered on the upper left corner

Environments observed

English beta cluster

Browser Version:

IE 11

OS Version:

Windows

Device Model:

Desktop

Device Language:

English

Developer notes

#mwe-popups-settings is position fixed, as is its parent container #mwe-popups-overlay
This seems redundant
Making #mwe-popups-settings position relative seems to solve the problem
This can easily be replicated in browser stack Windows 7/IE11 and there are also developer tools for it.

QA steps

This should be tested on the beta cluster (https://en.wikipedia.beta.wmflabs.org)
This can easily be replicated in browser stack Windows 7/IE11
We'll want to confirm that the settings dialog is centered when opened.
Check Firefox and Chrome and other versions of Internet Explorer/Edge to confirm the positioning is consistent.

Details

	Subject	Repo	Branch	Lines +/-
	Fix IE11 settings dialog centering	mediawiki/extensions/Popups	master	+0 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T192622 [EPIC] Page previews post-deploy cleanup
		Resolved		ABorbaWMF	T192004 [Bug] [IE 11] Popups settings dialog is offcenter

Event Timeline

• Niedzielski created this task.Apr 11 2018, 5:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2018, 5:20 PM

• Niedzielski mentioned this in T165036: Refactor rendering code in src/renderer.js for readability and testability.Apr 11 2018, 5:21 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Apr 11 2018, 5:59 PM

Jdlrobson updated the task description. (Show Details)Apr 11 2018, 8:18 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

ovasileva triaged this task as Medium priority.Apr 12 2018, 3:59 PM

Aklapper added a project: Browser-Support-Internet-Explorer.Apr 12 2018, 4:30 PM

Jdlrobson added a parent task: T192622: [EPIC] Page previews post-deploy cleanup.Apr 20 2018, 12:50 AM

Maybe broken flex support? https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups/+/master/src/ui/settingsDialogRenderer.less#11

Jdlrobson set the point value for this task to 2.Apr 24 2018, 4:45 PM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.May 8 2018, 6:55 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.May 9 2018, 4:32 PM

ovasileva moved this task from Upcoming to 2017-18 Q4 on the Web-Team-Backlog board.

Jdrewniak moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.May 24 2018, 12:00 PM

Change 434902 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/Popups@master] Fix IE11 settings dialog centeringt

https://gerrit.wikimedia.org/r/434902

gerritbot added a project: Patch-For-Review.May 24 2018, 12:11 PM

Jdrewniak moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.May 24 2018, 12:11 PM

Jdrewniak claimed this task.May 24 2018, 12:22 PM

pmiazga claimed this task.May 29 2018, 8:31 AM

pmiazga added a subscriber: Jdrewniak.

pmiazga removed pmiazga as the assignee of this task.May 29 2018, 7:12 PM

pmiazga removed a project: Patch-For-Review.

pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

pmiazga subscribed.

Change 434902 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix IE11 settings dialog centering

https://gerrit.wikimedia.org/r/434902