Page MenuHomePhabricator
Create Task
Maniphest T192006

wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master
Closed, DeclinedPublic5 Estimated Story Points
Actions

Description

Currently the wdqs-frontend docker image builds from master, but only when build is manually triggered, or a new commit is made to wikibase-docker wmde git repo.

NEW IDEA

Use Blubber...
Do something after using blubber..

OLD IDEA
Instead some jenkins / github hook should hit the travis API / trigger a new build

As this requires a travis token it might be an idea to use a specific account for it that only has access to the wikibase-docker repo under the wmde org.
We have such a user, https://github.com/WikidataBuilder, the question is, who still has the password?

Possible solution
Triggering builds with the API: https://docs.travis-ci.com/user/triggering-build
Webhooks could also work but they would require some extra service to look at the webhooks and determine when the merge actually happened on master...
We could look into a gerrit plugin (as in T87768#3958112)

using the API...

We could create a tiny jenkins job triggering the travis API
The jenkins job could be small and generic, triggering the master build of the given github repo on travis.
Possible ENV vars for the image:

  • AUTH_HEADER (secret token)
  • REPO (example wmde/wikibase-docker)

This will require a travis user token for the requests..

We could also create a small travis job on the GUI repo... https://github.com/wikimedia/wikidata-query-gui triggering the same API request..

Details

SubjectRepoBranchLines +/-
WIP DNM add blubber.ymlwikidata/query/guimaster+91 -1
[WIP] [POC] Add blubber and turn it to a nodejs serve-static serverwikidata/query/guimaster+107 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
thcipriani added a comment.Sep 14 2018, 10:15 PM
In T192006#4579891, @Addshore wrote:

@thcipriani just checking, but this would result in an image of whatever is currently on master right?

Depends on how it's setup. For Mathoid a container is built and pushed to docker-registry.wikimedia.org/wikimedia/mediawiki-services-mathoid that is tagged with a timestamp. This currently happens for every merge to master if the tests are passing and helm test passes.

Addshore added a comment.Sep 17 2018, 6:49 AM
In T192006#4585126, @thcipriani wrote:
In T192006#4579891, @Addshore wrote:

@thcipriani just checking, but this would result in an image of whatever is currently on master right?

Depends on how it's setup. For Mathoid a container is built and pushed to docker-registry.wikimedia.org/wikimedia/mediawiki-services-mathoid that is tagged with a timestamp. This currently happens for every merge to master if the tests are passing and helm test passes.

Gotcha, that would work!

Addshore mentioned this in T203078: Create test system for WDQ UI.Sep 17 2018, 7:29 AM
Addshore moved this task from needs discussion or investigation to in progress on the Wikidata board.Sep 18 2018, 2:22 PM
Addshore moved this task from Misc to Doing on the Wikibase-Docker-2017+ board.Sep 19 2018, 10:46 AM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Sep 20 2018, 1:08 PM
akosiaris subscribed.Oct 3 2018, 1:06 PM
Addshore moved this task from Goals to CI & Testing on the [DEPRECATED] wdwb-tech board.Oct 8 2018, 12:48 PM
Addshore moved this task from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 9 2018, 4:31 PM

Moving back to Todo as I haven't had time to look at this and other stuff has now come up that is getting some more priority..

Addshore removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Nov 1 2018, 11:14 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Nov 1 2018, 11:16 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 8 2018, 12:35 PM
Addshore added a comment.EditedNov 8 2018, 1:45 PM

So, while trying to move this to blubber I hit the first issue.

$ docker run --rm -it wdqs-gui-test-$(date --iso)

> wikidata-query-gui@0.1.4 test /srv/service
> grunt test

>> Local Npm module "grunt-auto-install" not found. Is it installed?
>> Local Npm module "grunt-banana-checker" not found. Is it installed?
>> Local Npm module "grunt-contrib-clean" not found. Is it installed?
>> Local Npm module "grunt-contrib-concat" not found. Is it installed?
>> Local Npm module "grunt-contrib-copy" not found. Is it installed?
>> Local Npm module "grunt-contrib-cssmin" not found. Is it installed?
>> Local Npm module "grunt-contrib-htmlmin" not found. Is it installed?
>> Local Npm module "grunt-contrib-jshint" not found. Is it installed?
>> Local Npm module "grunt-contrib-less" not found. Is it installed?
>> Local Npm module "grunt-contrib-qunit" not found. Is it installed?
>> Local Npm module "grunt-contrib-uglify" not found. Is it installed?
>> Local Npm module "grunt-filerev" not found. Is it installed?
>> Local Npm module "grunt-jscs" not found. Is it installed?
>> Local Npm module "grunt-jsonlint" not found. Is it installed?
>> Local Npm module "grunt-merge-i18n" not found. Is it installed?
>> Local Npm module "grunt-shell" not found. Is it installed?
>> Local Npm module "grunt-stylelint" not found. Is it installed?
>> Local Npm module "grunt-usemin" not found. Is it installed?
Warning: Task "jshint" not found. Use --force to continue.

Aborted due to warnings.
npm ERR! Test failed.  See above for more details.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

It looks like this is due to the dockerfile generated by blubber doing the install of npm packages in one directory:

COPY --chown=65533:65533 ["package.json", "/opt/lib/"]
RUN cd "/opt/lib" && npm install

While having the project files in another dir

WORKDIR "/srv/service
.....
COPY --chown=65533:65533 [".", "."]

and apparently grunts require() method will always look for node_modules directory in the project dir, ignoring the ENV vars??

I guess a related ticket in grunt is https://github.com/gruntjs/grunt/issues/1214

Addshore renamed this task from wdqs-frontend docker image should rebuild automatically when a new patch is pushed to master to wdqs-frontend docker image should rebuild automatically when a new patch is pushed to master.Nov 8 2018, 1:51 PM
Addshore renamed this task from wdqs-frontend docker image should rebuild automatically when a new patch is pushed to master to wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master.
Addshore updated the task description. (Show Details)
Addshore added a project: Release Pipeline (Blubber).
Addshore moved this task from Backlog to Doing on the Release Pipeline (Blubber) board.
thcipriani added a comment.Nov 8 2018, 4:39 PM
In T192006#4731938, @Addshore wrote:

So, while trying to move this to blubber I hit the first issue.

$ docker run --rm -it wdqs-gui-test-$(date --iso)

> wikidata-query-gui@0.1.4 test /srv/service
> grunt test

>> Local Npm module "grunt-auto-install" not found. Is it installed?
>> Local Npm module "grunt-banana-checker" not found. Is it installed?
>> Local Npm module "grunt-contrib-clean" not found. Is it installed?
>> Local Npm module "grunt-contrib-concat" not found. Is it installed?
>> Local Npm module "grunt-contrib-copy" not found. Is it installed?
>> Local Npm module "grunt-contrib-cssmin" not found. Is it installed?
>> Local Npm module "grunt-contrib-htmlmin" not found. Is it installed?
>> Local Npm module "grunt-contrib-jshint" not found. Is it installed?
>> Local Npm module "grunt-contrib-less" not found. Is it installed?
>> Local Npm module "grunt-contrib-qunit" not found. Is it installed?
>> Local Npm module "grunt-contrib-uglify" not found. Is it installed?
>> Local Npm module "grunt-filerev" not found. Is it installed?
>> Local Npm module "grunt-jscs" not found. Is it installed?
>> Local Npm module "grunt-jsonlint" not found. Is it installed?
>> Local Npm module "grunt-merge-i18n" not found. Is it installed?
>> Local Npm module "grunt-shell" not found. Is it installed?
>> Local Npm module "grunt-stylelint" not found. Is it installed?
>> Local Npm module "grunt-usemin" not found. Is it installed?
Warning: Task "jshint" not found. Use --force to continue.

Aborted due to warnings.
npm ERR! Test failed.  See above for more details.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

It looks like this is due to the dockerfile generated by blubber doing the install of npm packages in one directory:

COPY --chown=65533:65533 ["package.json", "/opt/lib/"]
RUN cd "/opt/lib" && npm install

We've actually changed the way that works in blubber fairly recently. I just updated the releases to ensure that they're all at the latest v0.6.0 like the Debian package used for CI, Let me know if v0.6.0 works for you.

Addshore added a comment.Nov 9 2018, 9:31 AM

I was on this:

$ blubber --version
0.4.0+9bfa2dd

Will give it a go with this today :)

$ blubber --version
0.6.0+7450643
Addshore added a comment.EditedNov 9 2018, 11:59 AM

So, I gave it another go, and then realized that I wasn't running the docker build with --no-cache.
We might want to work --no-cache into the https://wikitech.wikimedia.org/wiki/Blubber#Example_usage section incase people like me forget.

I then also realized that my build was reading from an out of date Docker file from a previous test that was left in the project directory...
This dockerfile has something to do with the fact that the example command doesn't work on my system(probably a windows thing):

$ blubber ./.pipeline/blubber.yaml test | docker build --no-cache -t wdqs-gui-test-$(date --iso) -f - .
Incorrect function.

So I am using something like this instead:

blubber ./.pipeline/blubber.yaml test > Dockerfile && docker build --no-cache -t wdqs-gui-test-$(date --iso) . && rm Dockerfile

*continues plodding along*

gerritbot subscribed.Nov 9 2018, 1:10 PM

Change 472649 had a related patch set uploaded (by Addshore; owner: Addshore):
[wikidata/query/gui@master] WIP DNM add blubber.yml

https://gerrit.wikimedia.org/r/472649

gerritbot added a project: Patch-For-Review.Nov 9 2018, 1:10 PM
Addshore added a comment.Nov 9 2018, 1:12 PM

So I pushed a patch of my work in progress blubber file.

test currently fails as a qunit test fails:

Running "qunit:all" (qunit) task
Testing wikibase/tests/index.html ..........................................................................FF
>> wikibase.queryService.api.CodeSamples - simple
>> Message: could not load code samples
>> Actual: false
>> Expected: true
>> file:///srv/service/wikibase/tests/queryService/api/CodeSamples.test.js:55:17
>> fire@file:///srv/service/node_modules/jquery/dist/jquery.js:3268:36
>> fireWith@file:///srv/service/node_modules/jquery/dist/jquery.js:3398:11
>> file:///srv/service/node_modules/jquery/dist/jquery.js:3622:32

>> wikibase.queryService.api.CodeSamples - empty
>> Message: could not load code samples
>> Actual: false
>> Expected: true
>> file:///srv/service/wikibase/tests/queryService/api/CodeSamples.test.js:55:17
>> fire@file:///srv/service/node_modules/jquery/dist/jquery.js:3268:36
>> fireWith@file:///srv/service/node_modules/jquery/dist/jquery.js:3398:11
>> file:///srv/service/node_modules/jquery/dist/jquery.js:3622:32

Testing wikibase/tests/QueryHelper.html .....................................OK

development currently fails as for some reason some resources are not where they should be?

GET http://localhost:8080/style.css net::ERR_ABORTED 404 (Not Found)
less.js:860 Rendered http://localhost:8080/style.less successfully.
less.js:446 XHR finished loading: GET "http://localhost:8080/style.less".
less.js:860 CSS for http://localhost:8080/style.less generated in 1288ms
less.js:860 Less has finished. CSS generated in 1290ms
less.js:464 [Violation] 'readystatechange' handler took 1017ms
(index):473 GET http://localhost:8080/node_modules/jquery.i18n/libs/CLDRPluralRuleParser/src/CLDRPluralRuleParser.js net::ERR_ABORTED 404 (Not Found)
(index):474 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.js net::ERR_ABORTED 404 (Not Found)
(index):475 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.messagestore.js net::ERR_ABORTED 404 (Not Found)
(index):476 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.fallbacks.js net::ERR_ABORTED 404 (Not Found)
(index):477 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.parser.js net::ERR_ABORTED 404 (Not Found)
(index):478 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.emitter.js net::ERR_ABORTED 404 (Not Found)
(index):479 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.language.js net::ERR_ABORTED 404 (Not Found)
2
less.js:446 XHR finished loading: GET "http://localhost:8080/style.less".
(index):473 GET http://localhost:8080/node_modules/jquery.i18n/libs/CLDRPluralRuleParser/src/CLDRPluralRuleParser.js net::ERR_ABORTED 404 (Not Found)
(index):474 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.js net::ERR_ABORTED 404 (Not Found)
(index):475 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.messagestore.js net::ERR_ABORTED 404 (Not Found)
(index):476 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.fallbacks.js net::ERR_ABORTED 404 (Not Found)
(index):477 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.parser.js net::ERR_ABORTED 404 (Not Found)
(index):478 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.emitter.js net::ERR_ABORTED 404 (Not Found)
(index):479 GET http://localhost:8080/node_modules/jquery.i18n/src/jquery.i18n.language.js 404 (Not Found)
jquery.js:3600 [Violation] 'setTimeout' handler took 54ms
[Violation] Forced reflow while executing JavaScript took 30ms
jquery.js:3818 jQuery.Deferred exception: Cannot set property 'debug' of undefined TypeError: Cannot set property 'debug' of undefined
    at setLanguage (http://localhost:8080/wikibase/init.js:17:16)
    at HTMLDocument.<anonymous> (http://localhost:8080/wikibase/init.js:38:4)
    at mightThrow (http://localhost:8080/node_modules/jquery/dist/jquery.js:3534:29)
    at process (http://localhost:8080/node_modules/jquery/dist/jquery.js:3602:12) undefined
less.js:464 [Violation] 'readystatechange' handler took 157ms
less.js:446 XHR finished loading: GET "http://localhost:8080/style.less".

I haven't tested prep or production yet.

Addshore mentioned this in rWDQGee45cc1bfdc3: WIP DNM add blubber.yml.Nov 9 2018, 1:14 PM
Addshore added a comment.Nov 9 2018, 3:32 PM

PS2 @ https://gerrit.wikimedia.org/r/#/c/wikidata/query/gui/+/472649/2 has "test" and "development" fully working.
Now I just have to figure out what to do with "prep" and "production"

Addshore mentioned this in rWDQG02f75b68c644: WIP DNM add blubber.yml.Nov 9 2018, 3:34 PM
Addshore added a subtask: T209206: Wikidata Query GUI (wikidata/query/gui) fails tests on initial clone on Debian.Nov 12 2018, 12:07 PM
Addshore mentioned this in rWDQG42583468a961: WIP DNM add blubber.yml.Nov 12 2018, 12:37 PM
Addshore mentioned this in rWDQG5bc18dad073f: WIP DNM add blubber.yml.Nov 12 2018, 12:40 PM
Addshore added a subscriber: Joe.Nov 12 2018, 3:04 PM
Addshore mentioned this in rWDQG6edc8783541e: WIP DNM add blubber.yml.Nov 12 2018, 3:24 PM
Addshore mentioned this in T209292: Create a wmf production ready nginx image.Nov 12 2018, 3:35 PM
Addshore changed the task status from Open to Stalled.Nov 12 2018, 3:43 PM

I think this is pretty stalled until the child task regarding an nginx image can be resolved.

Addshore mentioned this in rWDQGe999430c6c46: WIP DNM add blubber.yml.Nov 13 2018, 9:36 AM
Lucas_Werkmeister_WMDE closed subtask T209206: Wikidata Query GUI (wikidata/query/gui) fails tests on initial clone on Debian as Resolved.Nov 13 2018, 6:48 PM
Addshore mentioned this in T210286: Create docker based CI job to build the wikidata-query-gui.Nov 23 2018, 10:01 PM
Addshore removed Addshore as the assignee of this task.Dec 12 2018, 2:03 PM
Addshore moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
hashar added a parent task: T210286: Create docker based CI job to build the wikidata-query-gui.Dec 31 2018, 11:00 AM
Lydia_Pintscher subscribed.Jan 3 2019, 11:32 AM

Should this stay in the camp iteration then?

Addshore added a comment.Jan 3 2019, 11:34 AM
In T192006#4851658, @Lydia_Pintscher wrote:

Should this stay in the camp iteration then?

I believe so, I think that is the purpose of the stalled column there now.
We still want to get this done as soon as it is unblocked, rather than removing it from the iteration and forgetting about it for months.

thcipriani moved this task from Doing to Backlog on the Release Pipeline (Blubber) board.Jan 8 2019, 5:38 PM
• LarsWirzenius subscribed.Jan 15 2019, 5:32 PM
thcipriani added a comment.Jan 15 2019, 5:53 PM

Is the nginx base image because you have both a nodejs service listening on a socket in addition to static files that need to be served?

Addshore moved this task from Back Burner 🏛️ to Blocked 🚧 on the User-Addshore board.Jan 17 2019, 5:18 PM
Addshore added a comment.Jan 31 2019, 3:13 PM
In T192006#4881895, @thcipriani wrote:

Is the nginx base image because you have both a nodejs service listening on a socket in addition to static files that need to be served?

No, it is currently only static files.
Node is needed to build them, but they can currently be served by any old webserver.

Addshore removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Feb 4 2019, 9:46 AM
Addshore moved this task from in progress to blocked on others on the Wikidata board.

Removing this from the campsite until it is unblocked.

gerritbot added a comment.Feb 9 2019, 5:30 PM

Change 489386 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikidata/query/gui@master] [WIP] [POC] Add blubber and turn it to a nodejs serve-static server

https://gerrit.wikimedia.org/r/489386

Ladsgroup mentioned this in rWDQGf1fbe62b5624: [WIP] [POC] Add blubber and turn it to a nodejs serve-static server.Feb 9 2019, 5:32 PM
Ladsgroup subscribed.Feb 9 2019, 5:37 PM

I added basic serve-static nodejs libraries that can unblock us from using nginx and it's a good direction to have a nodejs server (then we can inject configs, etc.).
Now I have two issues with prep and deployment:

  • prep needs to have env=prod, that makes npm omit installing lots of needed dependencies like grunt, grunt minifiers, etc.
  • Speaking of grunt, if I remove env=prod from prep step to make sure it works otherwise, it still fails because Gruntfile.js is not copied over before doing the build step:
 ---> Using cache
 ---> b35f86ac2d58
Step 11/34 : ENV APP_BASE_PATH="/srv/service"
 ---> Using cache
 ---> 425e1c70eded
Step 12/34 : COPY --chown=65533:65533 ["package.json", "./"]
 ---> Using cache
 ---> 2cdc1fc68e11
Step 13/34 : RUN npm install
 ---> Running in c065d9733907

(LOTS OF LOGS)

Removing intermediate container c065d9733907
 ---> aa4aed71ea93
Step 14/34 : RUN npm "run" "build"
 ---> Running in 131e5935908e

> wikidata-query-gui@0.1.4 build /srv/service
> grunt build

A valid Gruntfile could not be found. Please see the getting started guide for
more information on how to configure grunt: http://gruntjs.com/getting-started
Fatal error: Unable to find Gruntfile.

npm ERR! Linux 4.15.0-43-generic
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "build"
npm ERR! node v6.12.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! wikidata-query-gui@0.1.4 build: `grunt build`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the wikidata-query-gui@0.1.4 build script 'grunt build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the wikidata-query-gui package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     grunt build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs wikidata-query-gui
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls wikidata-query-gui
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /srv/service/npm-debug.log
The command '/bin/sh -c npm "run" "build"' returned a non-zero code: 1

There are two options now: 1- Move away from Grunt build step (doing it with Make? etc.) it's lots of work 2- Add support for Grunt builds to blubber.
@thcipriani do you think you can do the latter?

gerritbot added a comment.Apr 15 2019, 10:21 AM

Change 489386 abandoned by Ladsgroup:
[WIP] [POC] Add blubber and turn it to a nodejs serve-static server

Reason:
We are not doing this for now

https://gerrit.wikimedia.org/r/489386

hashar closed subtask T209292: Create a wmf production ready nginx image as Declined.Jun 21 2019, 6:48 AM
Addshore mentioned this in T214532: Wikidata logo takes too long to appear on the Query UI on Firefox.Jun 22 2019, 3:23 PM
Addshore mentioned this in T234644: Wikimedia Technical Conference 2019 Session: Release "strategies" for MediaWiki and other elements of Wikimedia platform, for safe and efficient deployment and hosting.Nov 4 2019, 12:28 PM
Lydia_Pintscher changed the task status from Stalled to Open.Nov 12 2019, 1:47 PM
Lydia_Pintscher added a project: Wikidata-Campsite.

Based on story time discussion: Marking this as unstalled because child task was resolved as declined.

Ladsgroup added a comment.Nov 12 2019, 8:44 PM

I'm in favor of turning the GUI into a nodejs app that serves static files for now and then slowly turning it into a full-fledged nodejs one. @Addshore do you think this is doable?

Addshore added a comment.Nov 15 2019, 2:13 PM
In T192006#5658106, @Ladsgroup wrote:

I'm in favor of turning the GUI into a nodejs app that serves static files for now and then slowly turning it into a full-fledged nodejs one. @Addshore do you think this is doable?

Yes

Addshore added a comment.EditedNov 15 2019, 2:13 PM

Related T238303: Define a release process for wdqs

Ladsgroup mentioned this in T238303: Define a release process for wdqs.Nov 18 2019, 4:17 PM
Addshore mentioned this in T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3).Nov 29 2019, 12:00 PM
Addshore changed the task status from Open to Stalled.EditedJan 16 2020, 11:36 PM
Addshore moved this task from In Progress to Blocked / Waiting / External on the Wikidata-Campsite board.

This ticket relates to the wmde supported ui docker image.
Marking this as stalled until the work in T241291 is done, the we can see how to move forward.

Addshore mentioned this in T241291: Simplify WDQS Packaging.Jan 22 2020, 11:46 AM
Jdforrester-WMF subscribed.Feb 19 2020, 12:30 AM
gerritbot added a comment.Apr 29 2020, 9:03 PM

Change 472649 abandoned by Addshore:
WIP DNM add blubber.yml

https://gerrit.wikimedia.org/r/472649

Addshore changed the task status from Stalled to Open.Sep 21 2020, 10:54 AM
Addshore moved this task from Blocked / Waiting / External to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore added a subscriber: WMDE-leszek.Sep 22 2020, 10:26 AM

Although this is currently in the backlog in a prioritized position it may be best tackled as a trailblaze rather than on campsite as pointed out by @WMDE-leszek
Thus if the story time gets to this ticket perhaps this should be evaluated and potentially skipped for the next one in the backlog?

WMDE-leszek moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Sep 29 2020, 1:22 PM
WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
WMDE-leszek moved this task from Wikidata-Campsite-Iteration-∞ (On Hold) to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
WMDE-leszek edited projects, added Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Maintenance_bot removed a project: Patch-For-Review.Sep 29 2020, 2:10 PM
WMDE-leszek added a comment.Sep 29 2020, 2:14 PM

Awaiting the task to be opened by @Addshore describing the current state of the next steps to take in this field

Addshore moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Needs Tech Work on the Wikidata-Campsite board.Oct 7 2020, 9:45 AM

Moving out of the backlog as this will be rewritten and proposed as T264710: Host static sites on kubernetes and we need some answers there before we can continue

Ladsgroup added a comment.Oct 8 2020, 7:25 AM

I want to point out that we don't necessary need nginx or any static file serving software in kubernetes to be able to move this. The GUI can be easily turned to a nodejs app or worst case, you can use https://www.npmjs.com/package/http-server to serve them.

• Pablo-WMDE subscribed.Oct 8 2020, 7:44 AM

don't necessary need nginx or any static file serving software
The GUI can be easily turned to a nodejs app

Using my complete lack of involvement for a light-hearted comment about the irony of this discussion.
Instead of managing the risk of an accepted technology that will enabled many we make teams individually resort to workarounds opening up more and potentially bigger problems in the process.

GreenReaper mentioned this in T264538: Release 1.35 version of wikibase docker image.Oct 20 2020, 2:06 PM
Addshore closed this task as Declined.Oct 28 2020, 7:46 PM

I'm going to decline this task for now.
The release strategy hike may end up deciding to do in this direction, but the reasons this ticket was created originally are far gone now.
T235639: Decouple Query Service UI deployment from Query Service deployment was merged into T241291: Simplify WDQS Packaging which is also now done.
The next step is further decoupling this deployment per T264710#6586070 and we can move on from there in the future.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL