Page MenuHomePhabricator
Create Task
Maniphest T192028

Change 'NaN' & 'Infinite' to something more helpful in metrics % change over the selected time range
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Some metrics (for eg: New registered users metric for Wikibooks - Bashkir & New Pages metric for Wikiquote – Bulgarian) returns change in range as 'NaN' & 'Infinite' respectively when the corresponding data is constant (=0) for the selected time range. We should display something better to which a wikistats user can relate to (possibly 0). Please refer the attached images for example.

Screen Shot 2018-04-09 at 6.37.57 PM.jpg (1×1 px, 175 KB)
Screen Shot 2018-04-17 at 5.26.23 PM.jpg (1×1 px, 176 KB)

Details

SubjectRepoBranchLines +/-
Changed 'NaN' and 'Infinite' to an appropriate message in metrics % change over the selected time rangeanalytics/wikistats2master+14 -4
Customize query in gerrit

Related Objects

Event Timeline

sahil505 created this task.Apr 11 2018, 8:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2018, 8:40 PM
mforns added a comment.Apr 11 2018, 9:13 PM

@sahil505
Good catch!
Feel free to work on this if you want.

gerritbot subscribed.Apr 12 2018, 5:22 AM

Change 425747 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Changed 'NaN' to 0 in metrics % change over the selected time range

https://gerrit.wikimedia.org/r/425747

gerritbot added a project: Patch-For-Review.Apr 12 2018, 5:22 AM
• fdans triaged this task as Medium priority.Apr 12 2018, 4:47 PM
• fdans moved this task from Incoming to Mentoring on the Analytics board.
• fdans added a project: Analytics-Kanban.
sahil505 mentioned this in T189964: GSoC Proposal 2018 : [Analytics] Improvements to Wikistats2 front-end.Apr 12 2018, 11:45 PM
• Nuria moved this task from Next Up to In Code Review on the Analytics-Kanban board.Apr 16 2018, 5:40 PM
sahil505 renamed this task from Change 'NaN' to something more helpful in metrics % change over the selected time range to Change 'NaN' & 'Infinite' to something more helpful in metrics % change over the selected time range.Apr 17 2018, 12:20 PM
sahil505 updated the task description. (Show Details)
gerritbot added a comment.Apr 17 2018, 7:31 PM

Change 425747 merged by Mforns:
[analytics/wikistats2@master] Changed 'NaN' and 'Infinite' to an appropriate message in metrics % change over the selected time range

https://gerrit.wikimedia.org/r/425747

mforns moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Apr 17 2018, 7:32 PM
• Nuria moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Apr 24 2018, 3:01 PM
• Nuria set the point value for this task to 1.
mforns closed this task as Resolved.May 7 2018, 8:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL