Page MenuHomePhabricator

eswiki: 'check if user is reported' always returns 'true' even if the user is not reported
Closed, ResolvedPublic

Description

The option to check if a user has been reported always returns that the user has been already reported even if that is not true. Spotted when using Huggle on eswiki.

Event Timeline

The local config looks good for me. Can you paste a link to the diff ?
Note that HG simply checks if the username/IP is already present somewhere in the report page.

@Framawiki Hi. Thanks for checking. There's no diff however. I got this when hitting "Report user" and then "Check if the user is reported" in the report form of Huggle. Thanks.

Petrb triaged this task as High priority.May 13 2018, 7:43 PM

I didn't even look on config page, because I am really busy with other tasks now, but I guess the problem is with regular expression for checks of report page. To debug this, you can probably copy paste the report and config page to test.wikipedia.org and test it there. The regex probably needs to be updated, I suppose you have same regex from english wikipedia which is designed for their report page.

I think you should change aiv-section:2 to aiv-section:0

Right now huggle adds the report to section 2, which is usually someone elses report

oh now I see this is not about adding new reports but checking existing reports

however what I posted is true as well, I think Huggle wouldn't be able to add new reports properly as of now

I implemented new option into 3.4.0 in project config which is a regular expression that can be used to find user on report page, this how you can use it:

# Change it so that it better matches the reported user
report-user-check-pattern: '.*$username.*'

@Petrb I'll add that to the Project:Huggle/config (would that work for config.yaml once we find time to do it?)

I think it should work for both

Petrb claimed this task.

reopen if it doesn't work