Page MenuHomePhabricator
Create Task
Maniphest T192046

Develop a newcomer bot for Gerrit
Closed, ResolvedPublic
Actions

Assigned To
srishakatux
Authored By
srishakatux
Apr 12 2018, 1:50 AM
Tags
Referenced Files
None
Subscribers
Aklapper
demon
greg
Jdforrester-WMF
Legoktm
mmodell
• MZMcBride
View All 19 Subscribers
Tokens
"Like" token, awarded by Volker_E."Love" token, awarded by xSavitar."Love" token, awarded by Chicocvenancio."Love" token, awarded by ssastry."Like" token, awarded by Jdforrester-WMF."Orange Medal" token, awarded by Krinkle."Yellow Medal" token, awarded by Tgr.

Description

As per conclusion in T188244#4089807, the goal of this task is to create a Gerrit newcomer bot that does two things:

  • Add a reviewer ("first-time-contributor") to a patch submitted by a first time contributor and upload a welcome message in a comment
  • Add contributors who have started contributing in the last three months with five patches open still to a group called "Newcomers."

That way this bot would help us in two ways: a) provides a solution to welcome newcomers to Gerrit and b) a process to query newcomer patches

Work in progress

See also

Related Objects
Search...

Event Timeline

srishakatux triaged this task as High priority.Apr 12 2018, 1:50 AM
srishakatux created this task.
Aklapper mentioned this in T73357: Add a welcome bot to Gerrit for first time contributors.Apr 12 2018, 7:42 AM
Aklapper added a comment.Apr 13 2018, 9:11 AM

How is this task different at all from T73357?

srishakatux merged a task: T73357: Add a welcome bot to Gerrit for first time contributors.Apr 13 2018, 8:14 PM
srishakatux added subscribers: Reedy, Legoktm, Tgr and 7 others.
hashar closed this task as a duplicate of T73357: Add a welcome bot to Gerrit for first time contributors.Apr 13 2018, 8:19 PM
srishakatux reopened this task as Open.Apr 18 2018, 12:06 AM
Aklapper added a comment.Apr 26 2018, 4:58 PM

Explicitly linking to examples from here: https://gerrit.git.wmflabs.org/r/#/c/135/ and (once it works) https://gerrit.git.wmflabs.org/r/#/q/ownerin:NEWCOMERS

srishakatux added a comment.May 3 2018, 3:15 AM

Update: the bot is now on Toolforge: https://tools.wmflabs.org/admin/tool/gerrit-newcomer-bot. The changes are currently applied to Gerrit's test instance: http://gerrit.git.wmflabs.org. An example of the changes in effect (via the running bot): https://gerrit.git.wmflabs.org/r/#/c/202/.

Tgr awarded a token.May 3 2018, 6:54 AM
Niharika added a comment.May 3 2018, 5:28 PM
In T192046#4177367, @srishakatux wrote:

Update: the bot is now on Toolforge: https://tools.wmflabs.org/admin/tool/gerrit-newcomer-bot. The changes are currently applied to Gerrit's test instance: http://gerrit.git.wmflabs.org. An example of the changes in effect (via the running bot): https://gerrit.git.wmflabs.org/r/#/c/202/.

Pretty cool! I have a suggestion - Maybe don't hardcode the message shown to the user in the bot code but have it pick it up from a mediawiki page, so it's easy to modify when needed, which I think will be frequent. So like, create a page such as this where the bot message goes and the bot makes an API call to get that text every time it makes a post (not too frequent, I think).
This will allow you to experiment with different messages more easily to see which ones are more effective without having to make a patch every time.

srishakatux added a comment.May 3 2018, 6:13 PM

@Niharika Thanks, good suggestion! I've filed an issue on the repo and will look into it.

Krinkle awarded a token.May 3 2018, 6:16 PM
srishakatux added a project: Gerrit.May 3 2018, 6:57 PM
srishakatux closed subtask T192126: Decide on the bot name and welcome message for first time contributors as Resolved.May 3 2018, 11:22 PM
demon added a comment.EditedMay 4 2018, 2:00 AM

Is @srishakatux an admin on mw.org? We want it to be a protected page to avoid vandalism....

I don't think a commit is that big of a deal to change the message--which I don't actually think will be tweaked all that much.

(Remember, we abstracted it to the config file and out of the code itself)

Jdforrester-WMF awarded a token.May 4 2018, 6:46 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
ssastry awarded a token.May 4 2018, 6:49 PM
Chicocvenancio awarded a token.May 4 2018, 6:54 PM
xSavitar awarded a token.May 4 2018, 7:10 PM
xSavitar added a subscriber: xSavitar.
qdinar added a subscriber: qdinar.May 5 2018, 9:34 PM

hello. seems this bot is working in gerrit and it has written same message twice in same change page. seems it writes after every patch set upload.

srishakatux added a comment.May 5 2018, 9:39 PM

@qdinar thanks for reporting! I noticed your patchset and filed an issue here. Will add a fix soon!

• Volker_E awarded a token.May 7 2018, 4:37 PM
srishakatux closed this task as Resolved.May 8 2018, 10:43 PM

All details are here: https://github.com/srish/gerrit-newcomer-bot

Aklapper moved this task from Backlog to May on the Developer-Advocacy (Apr-Jun-2018) board.May 9 2018, 8:15 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL