Page MenuHomePhabricator

Tools column responsiveness with VE Context tools minimum width
Open, NormalPublic

Description

As per T188072: CX-VE integration framework should have a way to use tools container for tools we are placing the VE context tools in CX tools column. VE context tools are defined with 400px width. So we have two problems

  • CX Tools column max width is 400px including margin. Effectively the content width is 380px. - This is addressed by increasing max width to 420 px in https://gerrit.wikimedia.org/r/c/425584/
  • CX translation view is responsive. The column widths get adjusted as per the viewport width. But the 400px requirement for VE context tools makes a constraint on reducing the tools column width less than 400px. Illustrated in below image:

Event Timeline

santhosh created this task.Apr 12 2018, 4:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2018, 4:52 AM

Change 425584 had a related patch set uploaded (by Santhosh; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Make tools column actually 400px wide

https://gerrit.wikimedia.org/r/425584

santhosh updated the task description. (Show Details)Apr 12 2018, 4:57 AM

Change 425584 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Make tools column actually 400px wide

https://gerrit.wikimedia.org/r/425584

Pginer-WMF triaged this task as Normal priority.

Inspectors, in particular, are going to require the full 400px.

This should no longer be a problem after T188823, which allowed the context item labels to wrap.