Page MenuHomePhabricator

Removal of license template isn't shown in visual diff
Closed, ResolvedPublic1 Estimated Story Points

Description

Per https://www.mediawiki.org/w/index.php?title=Topic:Uaepkg08qfdmgx4y&action=history

When you look at this diff https://commons.wikimedia.org/w/index.php?title=File:Max-Braun-Medaille.jpg&diff=294690253&oldid=294688617&diffmode=source , there's a redundant GFDL template being removed.
You just can't see any change in the visual diff version .
The expectation would be that the template is there, displayed in red/marked as removed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 425817 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Apply diff attributes to all elements in an about group

https://gerrit.wikimedia.org/r/425817

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders set the point value for this task to 1.

Change 425817 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Apply diff attributes to all elements in an about group

https://gerrit.wikimedia.org/r/425817

Change 426121 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b01968a7)

https://gerrit.wikimedia.org/r/426121

Change 426121 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b01968a7)

https://gerrit.wikimedia.org/r/426121

Deskana triaged this task as Medium priority.

Commons is not yet running the relevant code release (1.31.0-wmf.30), it's still on the previous week's one (1.31.0-wmf.29), as per https://commons.wikimedia.org/w/index.php?title=Special:Version, so I wouldn't expect this to be fixed yet.

And indeed, now that Commons has rolled over to the new code, it shows correctly.