Page MenuHomePhabricator
Create Task
Maniphest T192084

[FEAT] patrol.py: Add quit option
Closed, ResolvedPublic
Actions

Description

Steps to reproduce
Run this script (on example you can run with my username. You can use any user name that is registered of course.)
python pwb.py patrol -usercontribs:Zoranzoki21 -ask

Expected results
When script start with working, we should have and option for quit, as we have the confirmation and rejection patrolling the change.

See screenshot: https://snag.gy/jreHNi.jpg

Actual results
We do not have the option to interrupt the execution of the script. We can only skip changes with typing letter n.

Details

SubjectRepoBranchLines +/-
[WIP][bugfix] Rewrite patrol.pypywikibot/coremaster+176 -189
[FEAT] Add quit option in patrol.pypywikibot/coremaster+8 -5
Customize query in gerrit

Event Timeline

Kizule created this task.Apr 12 2018, 2:49 PM
Restricted Application added subscribers: pywikibot-bugs-list, Dvorapa, Aklapper. · View Herald TranscriptApr 12 2018, 2:49 PM
Kizule updated the task description. (Show Details)Apr 12 2018, 2:53 PM
Kizule renamed this task from [FEAT] patrol.py: Add quit option to [FEAT] patrol.py: Add quit option.Apr 12 2018, 4:06 PM
Xqt triaged this task as Low priority.Apr 12 2018, 7:05 PM

You can use ctrl-c keyboard interrupt but sure this could be nicer with quit option.

Xqt claimed this task.Apr 13 2018, 9:03 AM
Xqt added a project: good first task.
gerritbot subscribed.Apr 13 2018, 9:13 AM

Change 425981 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [FEAT] Add quit option in patrol.py

https://gerrit.wikimedia.org/r/425981

gerritbot added a project: Patch-For-Review.Apr 13 2018, 9:13 AM
gerritbot added a comment.Apr 13 2018, 3:21 PM

Change 426029 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Rewrite patrol.py

https://gerrit.wikimedia.org/r/426029

gerritbot added a comment.Apr 14 2018, 8:55 AM

Change 425981 merged by jenkins-bot:
[pywikibot/core@master] [FEAT] Add quit option in patrol.py

https://gerrit.wikimedia.org/r/425981

Xqt closed this task as Resolved.Apr 14 2018, 4:27 PM
Kizule reopened this task as Open.Apr 14 2018, 4:31 PM

No, this no work as expected as I was told. Option should immediately stop execution, not switch to the next change. For that I have an option already.

I really no know why is patch merged?

zhuyifei1999 subscribed.Apr 14 2018, 5:47 PM

Test case? Expected behavior? Actual behavior?

Kizule added a comment.Apr 14 2018, 6:44 PM

Actual behaviour is to script no stop executing. It show next change. Expected behaviour I was told:

In T192084#4131786, @Zoranzoki21 wrote:

No, this no work as expected as I was told. Option should immediately stop execution, not switch to the next change. For that I have an option already.

I really no know why is patch merged?

Xqt added a comment.Apr 15 2018, 6:48 AM
In T192084#4131885, @Zoranzoki21 wrote:

Actual behaviour is to script no stop executing. It show next change.

This is not true. It does not continue with the next change but with the next "recentchange" generator. The first generator was "newpages". Both is shown in the command line.

Xqt lowered the priority of this task from Low to Lowest.Apr 15 2018, 6:48 AM
Kizule closed this task as Resolved.Apr 17 2018, 4:22 AM

Work as expected. I no know how.

But, thank you very much! https://snag.gy/DgPw9n.jpg

Xqt added a comment.Apr 17 2018, 5:19 PM
In T192084#4135172, @Zoranzoki21 wrote:

Work as expected. I no know how.

I know it.

gerritbot added a comment.Feb 21 2021, 11:36 AM

Change 426029 abandoned by Xqt:
[pywikibot/core@master] [WIP][bugfix] Rewrite patrol.py

Reason:
no longer maintained

https://gerrit.wikimedia.org/r/426029

Xqt removed a project: Patch-For-Review.Apr 5 2021, 5:04 PM

Done with https://gerrit.wikimedia.org/r/425981

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL