Page MenuHomePhabricator
Create Task
Maniphest T192117

Tabbing on the caption field gives error "Uncaught TypeError: selection.isSingleCell is not a function"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps:

  1. Insert a table
  2. Place your cursor on the caption field
  3. Press Tab

The following error appears:
Uncaught TypeError: selection.isSingleCell is not a function

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (8b01968a7)mediawiki/extensions/VisualEditormaster+1 -1
Ignore tab key when in table captionVisualEditor/VisualEditormaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 12 2018, 10:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2018, 10:08 PM
Esanders claimed this task.Apr 13 2018, 4:42 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders set the point value for this task to 1.
gerritbot subscribed.Apr 13 2018, 4:43 PM

Change 426109 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Ignore tab key when in table caption

https://gerrit.wikimedia.org/r/426109

gerritbot added a project: Patch-For-Review.Apr 13 2018, 4:43 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 13 2018, 4:43 PM
Jdforrester-WMF added a project: VisualEditor-Tables.Apr 13 2018, 4:46 PM
Jdforrester-WMF mentioned this in T192163: Users can't tab into or out of table captions.Apr 13 2018, 5:33 PM
Jdforrester-WMF mentioned this in T192164: Users can't tab into or out of table captions.
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Apr 13 2018, 5:40 PM

Change 426109 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Ignore tab key when in table caption

https://gerrit.wikimedia.org/r/426109

gerritbot added a comment.Apr 13 2018, 5:48 PM

Change 426121 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b01968a7)

https://gerrit.wikimedia.org/r/426121

gerritbot added a project: Patch-For-Review.Apr 13 2018, 5:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.Apr 13 2018, 6:46 PM
gerritbot added a comment.Apr 13 2018, 6:57 PM

Change 426121 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b01968a7)

https://gerrit.wikimedia.org/r/426121

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)).Apr 13 2018, 7:00 PM
Ryasmeen added a project: Verified.Apr 13 2018, 10:10 PM
• Deskana closed this task as Resolved.Apr 16 2018, 2:11 PM
• Deskana triaged this task as Medium priority.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 16 2018, 2:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL