| Schnark | |
| Apr 13 2018, 8:47 AM |
| F17097598: image.png | |
| Apr 18 2018, 8:08 PM |
| F17097595: image.png | |
| Apr 18 2018, 8:08 PM |
On https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Letzte_%C3%84nderungen?enhanced=1 (i.e. Recent Changes with page grouping enabled), the triangular icons to expand/collapse the group of changes to the same page are now surrounded with square brackets, which degrades the design.
This is probably caused by rMW46a7aa7e3e8e: jquery.makeCollapsible: Use pseudo elements for square brackets around toggle.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | • thcipriani | T183969 1.31.0-wmf.30 deployment blockers | ||
| Resolved | • matmarex | T192140 Square brackets shown around the expand/collapse icons on RC |
This happens also on mediawiki.org now, see T192435
Raising priority before it impacts actual wikipedias
Seems like a small visual regression. Should this block train? Adding @Konfused-Kitten as the author and @Krinkle as committer.
Also adding @Jdlrobson since he was the author according to https://gerrit.wikimedia.org/r/#/c/424164/3 (not sure why rMW46a7aa7e3e8e shows something different)
Change 427476 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Recent Changes should disable pseudo elements around collapse controls
Change 427478 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles
This affects other pre-generated toggles too, e.g. "Pre-made toggle" on https://www.mediawiki.org/wiki/Manual:Collapsible_elements/Demo/Advanced
Change 427476 abandoned by Jdlrobson:
Recent Changes should disable pseudo elements around collapse controls
Reason:
your approach is much better yes
Change 427478 merged by jenkins-bot:
[mediawiki/core@master] jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles
Change 427709 had a related patch set uploaded (by Thcipriani; owner: Bartosz Dziewoński):
[mediawiki/core@wmf/1.31.0-wmf.30] jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles
Change 427709 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.30] jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles
Mentioned in SAL (#wikimedia-operations) [2018-04-19T18:32:58Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.30/resources/src/jquery: [[gerrit:427709|jquery.makeCollapsible: Only add "[" "]" to autogenerated toggles]] T192140 (duration: 01m 17s)
Change 427762 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@REL1_31] jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles
Change 427762 merged by jenkins-bot:
[mediawiki/core@REL1_31] jquery.makeCollapsible: Only add '[' ']' to autogenerated toggles