Maniphest T192210

Loading animation is over text on Recent Changes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jack_who_built_the_house
	Apr 14 2018, 4:51 PM

Description

When new changes arrive and you click "View new changes", an ellipsis animation appears on top of the results area. It appears at the same level as the level the first line is at, overlaying the top of the characters. For my taste, this looks clumsy.

I would've expected something like this:

This is because of margin-top: 2em; in mw.rcfilters.less:

body.mw-rcfilters-ui-loading .rcfilters-spinner {
  display: block;
  // When loading new results, display the spinner on top of the results area
  margin-top: 2em;
}

On the second image, margin-top property is removed.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Align loading animation for first load later reloads	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T192275: Fix "Tags" padding to have it less close to the edge

Event Timeline

Jack_who_built_the_house created this task.Apr 14 2018, 4:51 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 14 2018, 4:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jack_who_built_the_house updated the task description. (Show Details)Apr 14 2018, 7:01 PM

Trizek-WMF renamed this task from Fix a couple of visual issues with the new filters UI to Loading animation is over text on Recent Changes.Apr 16 2018, 12:47 PM

Trizek-WMF removed a project: Design.

Trizek-WMF updated the task description. (Show Details)

I've renamed that task and move the second part of the task to T192275: Fix "Tags" padding to have it less close to the edge to handle it.

Thank you for the report @Jack_who_built_the_house. Please create separate tasks for issues that are really different. Those were related but different (animation versus padding).

Trizek-WMF removed a subtask: T192275: Fix "Tags" padding to have it less close to the edge.Apr 16 2018, 12:50 PM

Thanks for the split, I will do as you advise next time.

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter), good first task; removed Collaboration-Team-Triage.May 3 2018, 1:28 AM

• jmatazzoni moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Trizek-WMF added a project: User-notice-collaboration.May 18 2018, 1:17 PM

Jack_who_built_the_house updated the task description. (Show Details)May 18 2018, 6:19 PM

Mooeypoo assigned this task to Hagarshilo.Jun 11 2018, 4:28 PM

Mooeypoo moved this task from Snack Box to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Change 440075 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/core@master] Remove loading animation top margin to prevent it from covering text

https://gerrit.wikimedia.org/r/440075

gerritbot added a project: Patch-For-Review.Jun 13 2018, 8:37 AM

Hagarshilo moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 13 2018, 8:37 AM

Change 440075 merged by jenkins-bot:
[mediawiki/core@master] Align loading animation for first load later reloads

https://gerrit.wikimedia.org/r/440075

Hagarshilo moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 26 2018, 6:27 AM