Page MenuHomePhabricator

VE is creating internal <span> tags in the end result
Closed, ResolvedPublic


In this edit on frwiki, VE created several <span> tags with internal attributes (data-ve-attributes...). It also added some href attributes to small tags. It also replaced italic formatting with 2 singles quotes by <i> tags.

In the next edit, it did similar things, with also the replacement of list items (*) by li or ul tags...

Same kind of problems for the third edit.

Please fix this issue because it means a lot of work to fix the problems in articles

Event Timeline

Similar issues on article Nafessa Williams, on article Amanda Peet and several others... Apparently many edits from user Stef 10 show the problem.

I think I have fixed about 20 articles with similar problems from the Stef 10's contibutions. That's a lot of work, please fix quickly...

For example, on Elizabeth Reaser:

  • The first 3 modifications are OK
  • The 4th one begins to have problems (only span tags with ve internal attributes)
  • Modifications after that are becoming increasingly problematic

Change 426941 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Always remove data-ve-attributes on external paste

data-ve-attributes means the cause is the user pasting from another article, however I can't reproduce this bug. I've looked at the codepath, and the only way for the attribute to not get removed is if the JSON didn't parse, but looking at the saved wikitext that shouldn't be the problem here. The patch above removes the dependency on the JSON parsing, but without reproduction steps, I'm not sure it will fix the issue.

Change 426941 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Always remove data-ve-attributes on external paste

Change 427154 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1185206ee)

Change 427154 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1d00a1715)

Deskana subscribed.

It's difficult to say since reproduction was not possible, but hopefully this resolves the issue.

I hope this is over and deployed because fixing the articles takes a very long time...

Have you noticed that the attributes added by VE are often meaningless : href attributes with text only, not related to the article (like coming from an other article) ?