I have seen a break(2) where the parenthesis are not needed and it looks like a function.
The parenthesis should be removed.
break and continue can get these numbers
while ( !$stack->isEmpty() ) {
....
foreach ( $node->mChildren as $child ) {
if ( $child->mWithinTreeMatchCount > 0 ) {
if ( $nodeCount >= $wgCargoMaxVisibleHierarchyDrilldownValues ) {
break(2);
}
$queue->enqueue( $child );
$nodeCount++;
}
}
}Maybe the sniff could remove the default of 1 as a second feature.
[1] https://gerrit.wikimedia.org/r/#/c/426266/2/drilldown/CargoDrilldownHierarchy.php