Maniphest T192264

Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This comes down to EditEntity::clearEntity which will make an api request to wbeditentity for a lexeme with the clear parameter forget about the formid counter.

Details

Subject	Repo	Branch	Lines +/-
Test that using clear with wbeditentity does not reset nextFormId for lexemes	mediawiki/extensions/WikibaseLexeme	master	+30 -0
Let entities clear themselves	mediawiki/extensions/Wikibase	master	+15 -21
Implement ClearableEntity for Form and Lexeme	mediawiki/extensions/WikibaseLexeme	master	+129 -3
Update wikibase/data-model to 7.5.0	mediawiki/vendor	master	+146 -105

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T194253 Configure the CI job that runs WikibaseLexeme's browser tests against test wikidata
Resolved	Addshore	T168260 Deploy WikibaseLexeme extension on Wikimedia cluster
Resolved	Addshore	T191457 Deploy WikibaseLexeme on www.wikidata.org
Resolved	Addshore	T191458 Deploy WikibaseLexeme on test.wikidata.org
Resolved	Lydia_Pintscher	T168263 WikibaseLexeme functional baseline
Resolved	Jakob_WMDE	T192264 Clearing a Lexeme via wbeditentity will reset the FormId counter for the entity.

Event Timeline

Addshore created this task.Apr 16 2018, 11:04 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptApr 16 2018, 11:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jakob_WMDE subscribed.Apr 16 2018, 11:05 AM

It might make sense for EntityDocument to have a clear() method in the interface. This could also be in some other service and not attached to the document itself.

Then in EditEntity::clearEntity instead of creating a new Entity you could create a copy() and call clear() which would have special handling for Lexeme (and also special handling for Property, which is currently hard coded in EditEntity)

WMDE-leszek set the point value for this task to 3.Apr 17 2018, 3:24 PM

WMDE-leszek moved this task from incoming to Features/bugs for first release on the Wikidata Lexicographical data board.

Addshore added a parent task: T168263: WikibaseLexeme functional baseline.Apr 17 2018, 3:25 PM

Jakob_WMDE claimed this task.Apr 27 2018, 2:41 PM

Jakob_WMDE added a project: Wikidata-Turtles-Sprint#4.

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Turtles-Sprint#4 board.

Change 429792 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] [DNM] Let entities clear themselves

https://gerrit.wikimedia.org/r/429792

gerritbot added a project: Patch-For-Review.Apr 30 2018, 12:49 PM

PR on GitHub: https://github.com/wmde/WikibaseDataModel/pull/776

In T192264#4168396, @Jakob_WMDE wrote:

PR on GitHub: https://github.com/wmde/WikibaseDataModel/pull/776

PR merged, and 7.4.0 of DataModel released.

Change 430327 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/vendor@master] Update wikibase/data-model to 7.4.0

https://gerrit.wikimedia.org/r/430327

Change 430372 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Implement ClearableEntity for Form and Lexeme

https://gerrit.wikimedia.org/r/430372

Jakob_WMDE mentioned this in rEWLE3455c4722733: Implement ClearableEntity for Form and Lexeme.May 2 2018, 1:47 PM

Change 430386 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Test that using clear with wbeditentity does not reset nextFormId for lexemes

https://gerrit.wikimedia.org/r/430386

Jakob_WMDE mentioned this in rEWLE04f658d42612: Test that using clear with wbeditentity does not reset nextFormId for lexemes.May 2 2018, 2:32 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Turtles-Sprint#4 board.May 2 2018, 2:33 PM

Jakob_WMDE mentioned this in rEWLEc2e802403db1: Test that using clear with wbeditentity does not reset nextFormId for lexemes.May 2 2018, 2:37 PM

Jakob_WMDE mentioned this in rEWLEde55af3b8290: Test that using clear with wbeditentity does not reset nextFormId for lexemes.May 2 2018, 2:50 PM

Jakob_WMDE mentioned this in rEWLE343444c96ef8: Implement ClearableEntity for Form and Lexeme.May 2 2018, 3:45 PM

Jakob_WMDE mentioned this in rEWLEcd7a5167a6be: Implement ClearableEntity for Form and Lexeme.May 2 2018, 3:53 PM

Jakob_WMDE mentioned this in rEWLE8f9c30ad0318: Test that using clear with wbeditentity does not reset nextFormId for lexemes.

Jakob_WMDE mentioned this in rEWLEf5ea5ee95a1a: Implement ClearableEntity for Form and Lexeme.May 3 2018, 9:23 AM

Jakob_WMDE mentioned this in rEWLE3c500a4b6bfa: Implement ClearableEntity for Form and Lexeme.May 3 2018, 9:35 AM

Change 430327 merged by jenkins-bot:
[mediawiki/vendor@master] Update wikibase/data-model to 7.5.0

https://gerrit.wikimedia.org/r/430327

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 3 2018, 10:00 AM

Jakob_WMDE mentioned this in rEWLE5c918230b4a4: Implement ClearableEntity for Form and Lexeme.May 4 2018, 9:52 AM

Change 430372 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Implement ClearableEntity for Form and Lexeme

https://gerrit.wikimedia.org/r/430372

Change 429792 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Let entities clear themselves

https://gerrit.wikimedia.org/r/429792

Jakob_WMDE mentioned this in rEWLE1b06df5b932b: Test that using clear with wbeditentity does not reset nextFormId for lexemes.May 4 2018, 11:48 AM

Change 430386 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Test that using clear with wbeditentity does not reset nextFormId for lexemes

https://gerrit.wikimedia.org/r/430386

Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-Sprint#4 board.May 4 2018, 12:05 PM

Can we have an example link/edit? Thanks! :)

@Lydia_Pintscher https://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L587&action=history