Page MenuHomePhabricator
Create Task
Maniphest T192333

Abort dialog in mobile source editing should feature primary destructive button
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Volker_E
Apr 17 2018, 4:27 AM
Tags
Referenced Files
F26221761: image.png
Sep 27 2018, 6:59 PM
F17202606: abort-edit-primary-destructive.png
Apr 20 2018, 9:24 PM
F17020783: image.png
Apr 17 2018, 4:27 AM
Subscribers
Aklapper
• alexhollender_WMF
Esanders
gerritbot
• iamjessklein
Jdlrobson
Nikerabbit
View All 9 Subscribers

Description

Current abort dialog in mobile editing looks like this:

image.png (660×2 px, 63 KB)

The OK button should

  • be called differently, for example “Abandon change”
  • use a primary destructive button.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use upstream AbandonEditDialogmediawiki/extensions/MobileFrontendmaster+13 -8
Upstream VE's MWCancelConfirmDialog as AbandonEditDialogmediawiki/coremaster+62 -0
Use upstream AbandonEditDialogmediawiki/extensions/VisualEditormaster+8 -58
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Apr 17 2018, 4:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2018, 4:27 AM
pmiazga added a project: Web-Team-Backlog-Archived.Apr 17 2018, 8:40 PM
pmiazga subscribed.Apr 17 2018, 8:54 PM

/cc @alexhollender

ovasileva edited projects, added Web-Team-Backlog-Archived (Design); removed Web-Team-Backlog-Archived.Apr 18 2018, 10:22 AM
• alexhollender_WMF added a comment.Apr 20 2018, 9:24 PM

@pmiazga here's how it should look

abort-edit-primary-destructive.png (1×848 px, 176 KB)

Jdlrobson added a project: OOUI.Apr 20 2018, 9:38 PM

This is in the ooui library i believe.

Volker_E edited projects, added VisualEditor, UI-Standardization; removed OOUI.Apr 24 2018, 11:00 PM

@Jdlrobson You can make the Discard button whatever you want in OOUI.

Jdlrobson added a comment.Apr 24 2018, 11:03 PM

@VolkerE code is here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.editor.common/EditorOverlayBase.js#L313 and it's using the default OO ui widget. I'd argue the defaults should be sensible and in line with our palette. I'd hate to decide further down the line they should all be purple and have to update in say 10 places the color.

• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.May 1 2018, 6:48 PM
Esanders added a project: VisualEditor-MediaWiki-Mobile.Sep 27 2018, 6:57 PM
Esanders subscribed.Sep 27 2018, 6:59 PM
This comment was removed by Esanders.
Esanders added a comment.Oct 23 2018, 10:53 PM

We use this text in VE:

image.png (750×457 px, 84 KB)

Happy to tweak that if necessary but we should be consistent. We could upstream this dialog to master as "AbandonEditDialog"...

gerritbot subscribed.Oct 23 2018, 10:59 PM

Change 469340 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Make primary action destructive on abandon edit dialog

https://gerrit.wikimedia.org/r/469340

gerritbot added a project: Patch-For-Review.Oct 23 2018, 10:59 PM
gerritbot added a comment.Oct 31 2018, 1:33 PM

Change 470831 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Upstream VE's MWCancelConfirmDialog as AbandonEditDialog

https://gerrit.wikimedia.org/r/470831

gerritbot added a comment.Oct 31 2018, 1:38 PM

Change 470833 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use upstream AbandonEditDialog

https://gerrit.wikimedia.org/r/470833

Esanders added a subscriber: Nikerabbit.Oct 31 2018, 1:54 PM

This involves moving message defined in VE to core, pinging @Nikerabbit to see if we can preserve these.

Nikerabbit added a comment.Oct 31 2018, 2:19 PM

I replied on IRC but copying here:

I would do move and rename as two independent steps (and CC Raymond so he can perform the renames). Moving works across repos works if the key (aka page title) is exactly the same in translatewiki.net

Assuming this is the VE extension, then moving across repos will be easy because all MediaWiki core and extension keys share the same namespace.

Esanders added a comment.Oct 31 2018, 2:53 PM

Thanks, I've separated the move/rename steps into two patches.

gerritbot added a comment.Nov 5 2018, 6:19 PM

Change 470831 merged by jenkins-bot:
[mediawiki/core@master] Upstream VE's MWCancelConfirmDialog as AbandonEditDialog

https://gerrit.wikimedia.org/r/470831

gerritbot added a comment.Nov 5 2018, 6:19 PM

Change 470833 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use upstream AbandonEditDialog

https://gerrit.wikimedia.org/r/470833

gerritbot added a comment.Nov 5 2018, 6:19 PM

Change 469340 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use upstream AbandonEditDialog

https://gerrit.wikimedia.org/r/469340

Jdforrester-WMF assigned this task to Esanders.Nov 5 2018, 6:26 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
Volker_E added a subscriber: • iamjessklein.Nov 5 2018, 6:38 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 5 2018, 7:00 PM
Ryasmeen renamed this task from Abort dialog in mobile editing should feature primary destructive button to Abort dialog in mobile source editing should feature primary destructive button.Nov 6 2018, 1:13 AM
Ryasmeen added a project: Verified.
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Jdlrobson edited projects, added Web-Team-Backlog-Archived (Tracking); removed Web-Team-Backlog-Archived (Design).Nov 13 2018, 9:49 PM
• marcella closed this task as Resolved.Nov 19 2018, 4:31 PM
matmarex mentioned this in T151112: Rephrase MobileFrontend dialog controls/buttons when pressing the back arrow during an edit.May 1 2019, 9:38 PM
matmarex added a parent task: T151112: Rephrase MobileFrontend dialog controls/buttons when pressing the back arrow during an edit.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits