Maniphest T192378

Comment and transclusions in headings are misaligned
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DLynch
	Apr 17 2018, 3:56 PM

Description

A comment or transclusion contained within a heading gets misaligned. This is visible in core (see: demo/comments.html), but is particularly bad in MW because the content is hidden as well.

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (1d00a1715)	mediawiki/extensions/VisualEditor	master	+1 -1
	FocusableNode: Adjust alignment in headings	VisualEditor/VisualEditor	master	+5 -7

Customize query in gerrit

Related Objects

Mentioned Here: rGVED1d00a17158a4: Merge "FocusableNode: Adjust alignment in headings"

Event Timeline

DLynch created this task.Apr 17 2018, 3:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2018, 3:56 PM

Change 427167 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] FocusableNode: Adjust alignment in headings

https://gerrit.wikimedia.org/r/427167

gerritbot added a project: Patch-For-Review.Apr 17 2018, 4:35 PM

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 17 2018, 4:36 PM

Change 427167 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] FocusableNode: Adjust alignment in headings

https://gerrit.wikimedia.org/r/427167

matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 19 2018, 9:52 PM

matmarex removed a project: Patch-For-Review.

Change 427154 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1d00a1715)

https://gerrit.wikimedia.org/r/427154

gerritbot added a project: Patch-For-Review.Apr 20 2018, 2:59 PM

Change 427154 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1d00a1715)

https://gerrit.wikimedia.org/r/427154

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 20 2018, 5:00 PM

Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.Apr 20 2018, 6:38 PM

• Deskana closed this task as Resolved.Apr 23 2018, 9:56 AM

Ryasmeen added projects: Verified, Verified-in-Phase0.Apr 24 2018, 10:25 PM