Maniphest T192406

[BUG] Dragging cell for RTL article causes everything but thumbnail to be covered
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Apr 17 2018, 8:41 PM

Description

How many times were you able to reproduce it?

All

Steps to reproduce

Load an article like "enwiki > Food"
Tap the lang icon and select "Arabic"
Tap save icon
Go to either "Saved" or "History"
Drag the cell for the Arabic version of the article

Expected results

Normal drag behavior revealing share and delete icons at side of cell

Actual results

Funky times. The drag causes everything except the icon to be covered

Screenshots

Tap image for animation:

Environments observed

App version:
5.8
OS versions:
10.3.1
Device model:
All
Device language:
All

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Mhurd	T191862 Audit new reading list bits for RTL
		Resolved		Mhurd	T192406 [BUG] Dragging cell for RTL article causes everything but thumbnail to be covered

Event Timeline

Mhurd created this task.Apr 17 2018, 8:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2018, 8:41 PM

Mhurd added a parent task: T191862: Audit new reading list bits for RTL.Apr 17 2018, 10:54 PM

• JMinor triaged this task as Low priority.Apr 18 2018, 5:50 PM

• JMinor added a project: iOS-app-v5.8.1-Manatee-On-A-Scootscoot.

• JMinor edited projects, added iOS-app-v5.8.0-Manatee-On-A-Skateboard; removed iOS-app-v5.8.1-Manatee-On-A-Scootscoot.

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.

Mhurd claimed this task.Apr 18 2018, 5:59 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.

Mhurd updated the task description. (Show Details)

https://github.com/wikimedia/wikipedia-ios/pull/2233

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 8:39 PM

I checked my fix on iOS 10.3.1 and 11.2 and both EN and HE as device langs.

• NHarateh_WMF mentioned this in rAPIOSca5d04ba2abc: Merge pull request #2233 from wikimedia/fix/cell-swipe-rtl/T192406.Apr 18 2018, 9:06 PM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 9:17 PM

Mhurd moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 18 2018, 11:43 PM

Restricted Application added a project: Product-Analytics. · View Herald TranscriptApr 18 2018, 11:43 PM

• Phabricator_maintenance removed a project: Product-Analytics.Apr 19 2018, 12:24 AM

Working for me! No more weird center convergence!

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Apr 23 2018, 9:01 PM

Looks good to me on 5.8.1 (1394)

• JMinor closed this task as Resolved.May 3 2018, 6:35 PM

[BUG] Dragging cell for RTL article causes everything but thumbnail to be coveredClosed, ResolvedPublicActions