Page MenuHomePhabricator
Create Task
Maniphest T192407

Hide "Load more rows..." once all the data is visible in Table Chart
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

"Load more rows..." option in Table Chart continuous to be visible/clickable even after maximum rows/data is reached. We should hide this option as soon as all the data is visible.

Screen Shot 2018-04-18 at 2.11.35 AM.jpg (916×1 px, 171 KB)

Details

SubjectRepoBranchLines +/-
Hide "Load more rows..." once max data is visible in Table Chartanalytics/wikistats2master+18 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

sahil505 created this task.Apr 17 2018, 8:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2018, 8:49 PM
• Nuria added a comment.Apr 17 2018, 9:00 PM

Indeed, I tested this and completely missed this case, please be so kind to fix it.

sahil505 mentioned this in T189964: GSoC Proposal 2018 : [Analytics] Improvements to Wikistats2 front-end.Apr 18 2018, 2:11 PM
• fdans moved this task from Incoming to Mentoring on the Analytics board.Apr 19 2018, 4:45 PM
gerritbot subscribed.Apr 19 2018, 7:41 PM

Change 427774 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Hide "Load more rows..." once max data is visible in Table Chart

https://gerrit.wikimedia.org/r/427774

gerritbot added a project: Patch-For-Review.Apr 19 2018, 7:41 PM
mforns added a parent task: T189210: [Analytics] Improvements to Wikistats2 front-end .May 7 2018, 8:27 PM
mforns triaged this task as Medium priority.May 8 2018, 2:21 PM
mforns set the point value for this task to 3.
gerritbot added a comment.May 17 2018, 11:12 AM

Change 427774 merged by Mforns:
[analytics/wikistats2@master] Hide "Load more rows..." once max data is visible in Table Chart

https://gerrit.wikimedia.org/r/427774

sahil505 added a project: Analytics-Kanban.May 25 2018, 11:08 AM
sahil505 moved this task from Next Up to Ready to Deploy on the Analytics-Kanban board.
sahil505 moved this task from Ready to Deploy to Done on the Analytics-Kanban board.May 29 2018, 11:27 AM
• Nuria closed this task as Resolved.Jun 11 2018, 10:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL